[ 
https://issues.apache.org/jira/browse/HDDS-16826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18138567#comment-18138567
 ] 

Attila Doroszlai commented on HDDS-16826:
-----------------------------------------

On the other hand, a change related only to {{bats}} should not trigger full CI:

{code:title=https://github.com/apache/ozone/actions/runs/41979573507/job/127086316877?pr=11911#step:6:716}
  Changed files:
  
  dev-support/ci/pr_title_check.bats
  dev-support/ci/selective_ci_checks.bats
  hadoop-ozone/dev-support/checks/bats.sh
  hadoop-ozone/dev-support/checks/install/bats.sh

...
Check if everything should be run

  1 changed files matching the 
'^.github/workflows/check.yml|^.github/workflows/ci.yml|^.github/workflows/post-commit.yml|^dev-support/ci|^hadoop-ozone/dev-support/checks/_lib.sh'
 pattern, but ignoring 
'^dev-support/ci/pr_title_check|^dev-support/ci/find_test_class_project|^dev-support/ci/pr_body_config_doc.sh|^dev-support/ci/xml_to_md.py':
  
  dev-support/ci/selective_ci_checks.bats
  
  Important environment files changed. Running everything
{code}

> Selective checks: misc. files in repo root miscounted
> -----------------------------------------------------
>
>                 Key: HDDS-16826
>                 URL: https://issues.apache.org/jira/browse/HDDS-16826
>             Project: Apache Ozone
>          Issue Type: Sub-task
>          Components: CI
>            Reporter: Attila Doroszlai
>            Assignee: Attila Doroszlai
>            Priority: Major
>
> https://github.com/apache/ozone/pull/11439 changed 2 files:
> {code}
> THREAT_MODEL.md
> hadoop-hdds/common/src/main/resources/ozone-default.xml
> {code}
> Selective checks should run all tests (due to {{ozone-default.xml}}), but 
> only triggers {{rat}} and {{build}}, because:
> - {{get_count_misc_files}} matches for THREAT_MODEL.md
> - {{ozone-default.xml}} is not matched by any specific check
> - {{get_count_all_files}} returns 1 instead of 2 (ignores THREAD_MODEL.md)
> - {{COUNT_CORE_OTHER_CHANGED_FILES}} is (1 - 1 = 0) instead of (2 - 1 = 1).



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to