devmadhuu commented on code in PR #11926:
URL: https://github.com/apache/ozone/pull/11926#discussion_r4511912075
##########
hadoop-hdds/interface-client/src/main/proto/DatanodeClientProtocol.proto:
##########
@@ -577,6 +577,9 @@ message SendContainerRequest {
optional int64 checksum = 4;
optional CopyContainerCompressProto compression = 5;
optional int64 size = 6;
+ // StorageType the importing datanode should place the container on. Sent on
+ // the first request only, alongside size. Absent from older senders.
+ optional int32 storageTypeID = 7;
Review Comment:
The reason is the protobuf generation setup. `DatanodeClientProtocol.proto`
uses `Ratis’s` shaded protobuf library, while `StorageTypeProto `in
`hdds.proto` uses the regular protobuf library.
Directly importing that enum produces incompatible generated Java descriptor
types. The integer field carries the existing enum’s numeric value—for
example, SSD is 2—and `StorageTypeUtils` converts and validates it. This
follows the existing datanode request fields. Reusing the shared enum directly
would require broader protobuf-generation changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]