[
https://issues.apache.org/jira/browse/HDDS-17439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Siyao Meng updated HDDS-17439:
------------------------------
Description:
DN should validate block token from data stream committed PutBlocks.
There is already a built mechanism for block token validation. We only need to
enable it for STREAM_LINK and STREAM_COMMAND. STREAM_LINK is used for the end
of stream PutBlock while STREAM_COMMAND used for middle flushes PutBlock.
---
Found by code review of the datanode streaming PutBlock paths, as part of the
TLA+ verification effort under HDDS-15926, on commit
7212465c0bb19615708c144238317db51c2a696d. Checked against HDDS issues and
apache/ozone pull requests for duplicates before filing. Related but not
duplicates: HDDS-9697 (removed the token check from the state machine paths
other than {{startTransaction}}), HDDS-16008 (added the stream command),
HDDS-15792 (added the PutBlock at stream close), HDDS-16828 (finalized block
check on the same paths). The attached patch is a proposal for review.
Generated with Specula (Claude Opus 5.5).
was:
DN should validate block token from data stream committed PutBlocks.
There is already a built mechanism for block token validation. We only need to
enable it for STREAM_LINK and STREAM_COMMAND. STREAM_LINK is used for the end
of stream PutBlock while STREAM_COMMAND used for middle flushes PutBlock.
> Datanode does not check that a PutBlock committed through a data stream is
> for the stream's block and carries a valid block token
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: HDDS-17439
> URL: https://issues.apache.org/jira/browse/HDDS-17439
> Project: Apache Ozone
> Issue Type: Sub-task
> Components: Ozone Datanode
> Affects Versions: 1.4.0, 1.4.1, 2.3.0
> Reporter: Siyao Meng
> Assignee: Rui Wang
> Priority: Critical
> Labels: pull-request-available
> Fix For: 2.3.0
>
> Attachments: CR-3-check-stream-putblock-block-and-token.patch
>
>
> DN should validate block token from data stream committed PutBlocks.
> There is already a built mechanism for block token validation. We only need
> to enable it for STREAM_LINK and STREAM_COMMAND. STREAM_LINK is used for the
> end of stream PutBlock while STREAM_COMMAND used for middle flushes PutBlock.
> ---
> Found by code review of the datanode streaming PutBlock paths, as part of the
> TLA+ verification effort under HDDS-15926, on commit
> 7212465c0bb19615708c144238317db51c2a696d. Checked against HDDS issues and
> apache/ozone pull requests for duplicates before filing. Related but not
> duplicates: HDDS-9697 (removed the token check from the state machine paths
> other than {{startTransaction}}), HDDS-16008 (added the stream command),
> HDDS-15792 (added the PutBlock at stream close), HDDS-16828 (finalized block
> check on the same paths). The attached patch is a proposal for review.
> Generated with Specula (Claude Opus 5.5).
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]