chihsuan commented on code in PR #11924:
URL: https://github.com/apache/ozone/pull/11924#discussion_r4512951309


##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/heatMap/heatmap.tsx:
##########


Review Comment:
   I agree the backend is the right place to fix this. A follow-up also works 
for me, since this Jira is mainly about the hidden tiles. If we go that way, 
defaulting `color` to 0 in `updateSize` would keep cold keys from looking hot 
for now.



##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/v2/components/plots/heatmapPlot.tsx:
##########
@@ -131,10 +131,9 @@ const HeatmapPlot: React.FC<HeatmapPlotProps> = ({
         nodeClick: (event) => {
         var data = event.datum;
         // Leaf level box should not call API
-        if (!data.color)
-          if (data.path) {
-            onClick(data.path);
-          }
+        if (data.children?.length && data.path) {

Review Comment:
   Should we also update the group fixture in `HeatmapPlot.test.tsx`? I noticed 
its group tile has no `children`, so the "non-leaf group tile" click test now 
fails locally. Adding a child would match the API's group shape.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to