bharatviswa504 edited a comment on pull request #2432: URL: https://github.com/apache/ozone/pull/2432#issuecomment-895931056
> I revisted aws s3 documents, it seems that aws put object API only returns the latest object version-id when versioning is enabled(https://docs.aws.amazon.com/AmazonS3/latest/userguide/AddingObjectstoVersioningEnabledBuckets.html) , and return null when versioning is disabled. I have used latestVersion boolean in code, and by default it is true, so in that perspective we should be good. And as we have this flag to be consistent in code using this flag should be okay. In this way, we don't remove the old behavior completely. What returns null? I have not understood that part, care to explain more. > So I feel like we can make this " Return latest version of key location for client on createKey/createFile" a common logic, no need to depends on the getLatestVersionLocation value. It is more closer to the aws s3 behavior. We have 2 code paths, in both places when returning from network returning latest version. I am okay to do change with out using flag, but I think we can remove this every where if it is not required in read path also, as get by default returns latest version. So, this can be addressed in new Jira **Get behavior on version enabled buckets** Versioning in Amazon S3 is a way of keeping multiple variants of an object in the same bucket. A simple GET request retrieves the current version of an object. The following figure shows how GET returns the current version of the object, photo.gif. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
