ss77892 commented on PR #11874: URL: https://github.com/apache/ozone/pull/11874#issuecomment-6744190314
@rich7420 @yandrey321 Thanks for the reviews. I rebased onto current master as requested, with no code changes, so it now runs on grpc 1.82.4. The updates are in a new commit on top: - A stale abandon can no longer cancel a stream that has gone on to another request. - A reply with no request attached now drops the stream, instead of re-pooling it and throwing an NPE. - Added `ozone.client.grpc.pooled.streams.enabled` (default true) to turn pooling off. - Documented the `get()` contract and the span behaviour. I updated the Jira and the PR description to match the code, since the Jira described more than this PR does. Replies to the individual comments are inline, including the ones I'm not changing and why. `hdds-client` unit tests and checkstyle pass locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
