captainzmc commented on pull request #2495: URL: https://github.com/apache/ozone/pull/2495#issuecomment-895955262
> Two main comments: > > * Let's do not extend OutputStream in all the new classes in order to keep the code simple. If there is a need, we may add it later. > * In BlockDataStreamOutput, we should write directly to the underlying stream. We should not use BufferPool and ChunkBuffer in BlockDataStreamOutput anymore since we want to avoid buffer copying. Hi @szetszwo, Currently this PR already supports not extends OutputStream. Regarding the second problem mentioned above "not use BufferPool and ChunkBuffer to avoid buffer copying", As we discussed at the meeting on Monday, we are going to fix this in the next PR HDDS-5599. We will continue to optimize this client, for now let's make our client supports write a key use streaming first. So can you take another look at this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
