chungen0126 commented on PR #11505:
URL: https://github.com/apache/ozone/pull/11505#issuecomment-6765034440

   > * `scm --init` writes the VERSION file before initializing Ratis, so after 
a failed check, a rerun takes the "already initialized" branch and calls 
`initializeRatis` again with the same cluster ID. Is it fine to tell users to 
remove the stale directory and retry?
   
   I suggest follows the following workflow:
   1. Before the VERSION write, fail if the Ratis storage directory contains 
any Raft group directory, since a new cluster should have none.
   2. In SCMRatisServerImpl.initialize() and the constructor, before build(), 
fail if it contains a group other than this cluster's
   
   > * Do you know of any case where an SCM Ratis directory legitimately holds 
more than one group (e.g., after upgrading from the old shared `<meta>/ratis`)? 
Since [HDDS-7553](https://issues.apache.org/jira/browse/HDDS-7553) OM refuses 
to share it, I expect a strict check to be consistent.
   
   As I know SCM has a single Raft group derived from the cluster ID, so a 
strict check is fine.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to