[ 
https://issues.apache.org/jira/browse/HDDS-17764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18142069#comment-18142069
 ] 

Attila Doroszlai commented on HDDS-17764:
-----------------------------------------

I would like to argue with the goal of this task:

# {{MockDatanodeDetails}} and {{MockPipeline}} do create mock objects, since 
they do not reference real datanodes, addresses are random, etc.
# we would never possibly have classes named {{Mock...}} by following this 
logic, since Mockito provides generic mocking
# we have too many {{...TestUtils}} classes

I suggest renaming them to {{Stub}} or {{Fake}} if you prefer.

https://en.wikipedia.org/wiki/Mock_object

> MockDatanodeDetails and MockPipeline are not mocks.
> ---------------------------------------------------
>
>                 Key: HDDS-17764
>                 URL: https://issues.apache.org/jira/browse/HDDS-17764
>             Project: Apache Ozone
>          Issue Type: Improvement
>          Components: test
>            Reporter: Tsz-wo Sze
>            Assignee: Andy Huang
>            Priority: Minor
>              Labels: pull-request-available
>
> MockDatanodeDetails and MockPipeline are test utilities for creating *real* 
> DatanodeDetails and Pipeline objects but not mock objects (in the sense of 
> Mockito).
> Calling them "mock" is misleading.  These two classes are better to be 
> renamed to something like DatanodeDetailsTestUtils and PipelineTestUtils.



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to