chihsuan commented on code in PR #11938:
URL: https://github.com/apache/ozone/pull/11938#discussion_r4525256753
##########
hadoop-ozone/dist/src/main/k8s/examples/test-all.sh:
##########
@@ -44,15 +44,12 @@ for test in $(find "$SCRIPT_DIR" -name test.sh | grep
"${OZONE_TEST_SELECTOR:-""
echo "ERROR: Test execution of ${TEST_NAME} is FAILED!!!!"
fi
- cp "$TEST_DIR"/result/output.xml "$ALL_RESULT_DIR"/"${TEST_NAME}".xml || true
- mkdir -p "$ALL_RESULT_DIR"/"${TEST_NAME}"
- mv "$TEST_DIR"/logs/*log "$ALL_RESULT_DIR"/"${TEST_NAME}"/ || true
+ mv -fv "$TEST_DIR"/result "$ALL_RESULT_DIR"/"${TEST_NAME}" || true
+ mv -fv "$TEST_DIR"/logs/*log "$ALL_RESULT_DIR"/"${TEST_NAME}"/ || true
Review Comment:
Follow-up on the `CONTAINER` check: When the cluster never starts, there's
no `result` dir anymore, so the pod logs don't get moved here. Could we keep
`mkdir -p` between these two moves?
```suggestion
mv -fv "$TEST_DIR"/result "$ALL_RESULT_DIR"/"${TEST_NAME}" || true
mkdir -p "$ALL_RESULT_DIR"/"${TEST_NAME}"
mv -fv "$TEST_DIR"/logs/*log "$ALL_RESULT_DIR"/"${TEST_NAME}"/ || true
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]