smengcl commented on code in PR #114:
URL: https://github.com/apache/ozone-docker/pull/114#discussion_r4534437573
##########
.github/workflows/build-and-tag.yaml:
##########
@@ -23,6 +23,10 @@ on:
push:
branches:
- 'ozone-**'
+ paths:
Review Comment:
I think this filter may skip the release tagging. Release branches like
`ozone-2.2.2` are created at a commit that is already on `latest` (8ce987f), so
the push has no new commits and no changed files to match. GitHub does not
start a `paths` filtered workflow in that case.
We can already see it with `zizmor` and `ASF Allowlist Check` (both filtered
on `.github/workflows/**`). On 2026-10-30 they ran for `ozone-latest`, an
existing branch that moved forward
([zizmor](https://github.com/apache/ozone-docker/actions/runs/41077868311),
[ASF Allowlist
Check](https://github.com/apache/ozone-docker/actions/runs/41077868346)), but
not for the new `ozone-2.2.2` and `ozone-2.2.2-rocky` branches, where only the
unfiltered `build-and-tag` ran
([ozone-2.2.2](https://github.com/apache/ozone-docker/actions/runs/41077868506),
[ozone-2.2.2-rocky](https://github.com/apache/ozone-docker/actions/runs/41077869008);
see also the [zizmor runs filtered by branch
ozone-2.2.2](https://github.com/apache/ozone-docker/actions/workflows/zizmor.yml?query=branch%3Aozone-2.2.2),
which is empty). So with this change `build-and-tag` would likely not run for
the next `ozone-X.Y.Z` branch, and the version tag would not be pushed. The
[fork test](https://github.com/adoroszlai/ozone-docker
/actions/runs/42861522004) pushed this PR's own commit (which touches
`build-and-tag.yaml`) onto an existing branch, so it would not hit this case.
How about leaving `build-and-tag.yaml` without `paths`? It only runs for
`ozone-**` pushes, which are rare, and the reusable `build` job already skips
the build when the image for the SHA exists. That also covers a release commit
on `latest` that did not touch `Dockerfile`, where no image was built on the
push to `latest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]