chihsuan opened a new pull request, #12034: URL: https://github.com/apache/ozone/pull/12034
## What changes were proposed in this pull request? Requests that write a file each decide on their own which `OMDirectoryResult` values are errors after the path check. The copies have drifted: HDDS-17644 and HDDS-17696 were both a copy that missed a file in the parent path. This PR moves `OMFileCreateRequest.checkDirectoryResult` unchanged into `OMFileRequest`, and key create and the FSO multipart requests call it instead of their own copies. Result codes and check order do not change. Some exception messages now use the shared wording. ## What is the link to the Apache JIRA https://issues.apache.org/jira/browse/HDDS-17697 ## How was this patch tested? - `TestOMFileRequest` covers every `OMDirectoryResult` with and without overwrite. - New tests pin the current result codes when a directory exists at the key, for key create and FSO multipart initiate and complete. Each one fails if its call site drops the directory check. - Fixed an assertion from HDDS-17696 that always passed. - build-branch: https://github.com/chihsuan/ozone/actions/runs/43229475334 Generated-by: Claude Code (Claude Opus 5.5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
