errose28 commented on PR #12024:
URL: https://github.com/apache/ozone/pull/12024#issuecomment-6839571139

   The latest commits add test hardening, some improved logging, and a metric 
for failed pipeline closes.
   
   I agree that failure to close a pipeline is fine to block safemode exit. 
This indicates an internal error within the SCM. It was difficult to get a 
failed status from the scrubber into the pipeline safemode rule's status text, 
but hopefully both messages together with the metric will give enough of a 
picture.
   
   I'm still investigating reducing the background service boilerplate between 
`BackgroundPipelineScrubber`, `BackgroundPipelineCreator`, 
`SCMBackgroundService`, and `BackgroundService`. This will land in follow-up 
changes though.
   
   With Claude I was able to verify that no tests are restarting the cluster 
with some datanodes down, which would otherwise cause them to wait an extra 5 
minutes before scrubbing the previous pipelines and exiting safemode.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to