devmadhuu commented on PR #11988: URL: https://github.com/apache/ozone/pull/11988#issuecomment-6849591181
> [@devmadhuu](https://github.com/devmadhuu) thanks for the patch, change largely looks fine to me. Could we check the remaining getProtoBufMessage() call to ensure none of them serialize DB-loaded BlockData into responses where the container's StorageType is expected? The default method now uses the StorageType carried by BlockID, which will be null for newly persisted records. Thanks @ashishkumar50 for the review. I re-verified the remaining requests in `PutBlock`, `embedded PutBlock in WriteChunk,` and `PutSmallFile` serialize request-derived object. The closed-container reconciliation call is only used for a byte-count metric, and `GetSmallFile` returns `bytes/chunk` information rather than `BlockData`. I did not find any other DB-loaded BlockData response using the default serializer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
