smengcl commented on code in PR #12022:
URL: https://github.com/apache/ozone/pull/12022#discussion_r4548094997


##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestOzoneStoragePolicy.java:
##########
@@ -188,6 +190,47 @@ public void testKeyWithoutAnyPolicyUsesClusterDefault() 
throws Exception {
         OzoneStoragePolicy.getDefaultPolicy().getCreationTier());
   }
 
+  /**
+   * A file created with an explicit storage policy records that policy and 
lands
+   * on the policy's creation tier, in SCM and on the datanodes.
+   */
+  @ParameterizedTest

Review Comment:
   These two parameterized tests add four more all tier cluster starts (one per 
layout per method), on top of the one per test the class already has. Could the 
file path be covered by a single test that starts one cluster and loops over 
FILE_SYSTEM_OPTIMIZED and LEGACY?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to