smengcl commented on code in PR #12037:
URL: https://github.com/apache/ozone/pull/12037#discussion_r4558940880


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/diff/FullDiffSequentialReader.java:
##########
@@ -47,13 +47,13 @@
  * signature.
  *
  * <p>When an update-id gate is supplied (HA OM), to-side gating normally 
admits
- * rows with {@code updateID > fromSnapshotDbTxSequenceNumber}. HA OM write 
paths
+ * rows with {@code updateID} above the from snapshot's creation transaction 
index. HA OM write paths
  * are expected to bump {@code updateID} on every meaningful metadata change.
  * Rows with a missing {@code updateID}, {@code updateID == 0}, or
  * {@code updateID == DEFAULT_OM_UPDATE_ID} ({@code -1}) are always treated as
  * candidates as a conservative fallback for legacy or ambiguous rows.
  *
- * <p>When no gate is supplied (non-HA), every to-side row is a candidate and a
+ * <p>When no gate is supplied (non-HA or reverse diff), every to-side row is 
a candidate and a

Review Comment:
   nit: `resolveFullDiffUpdateIdGate` now also returns null when either 
snapshot has no `createTransactionInfo`. Could we list that case here too, e.g. 
"(reverse diff, or a snapshot without createTransactionInfo)", so the Javadoc 
matches the caller?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to