ss77892 commented on code in PR #11873:
URL: https://github.com/apache/ozone/pull/11873#discussion_r4571520271
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/utils/io/RandomAccessFileChannel.java:
##########
@@ -25,17 +25,25 @@
import java.nio.ByteBuffer;
import java.nio.channels.FileChannel;
import java.util.Objects;
+import org.apache.hadoop.hdds.client.BlockID;
+import org.apache.hadoop.ozone.container.common.helpers.BlockData;
import org.apache.ratis.util.Preconditions;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-/** {@link RandomAccessFile} and its {@link FileChannel}. */
+/**
+ * {@link RandomAccessFile} and its {@link FileChannel}. A ReadBlock stream
serves one block through one instance,
+ * which therefore also caches the block's {@link BlockData} and the read
buffer across the stream's requests.
+ */
public class RandomAccessFileChannel implements Closeable {
private static final Logger LOG =
LoggerFactory.getLogger(RandomAccessFileChannel.class);
private File blockFile;
private RandomAccessFile raf;
private FileChannel channel;
+ private BlockID cachedBlockID;
+ private BlockData cachedBlockData;
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]