Chi-Hsuan Huang created HDDS-17813:
--------------------------------------
Summary: Align where assumeS3Context overloads are declared in OM
protocol interfaces
Key: HDDS-17813
URL: https://issues.apache.org/jira/browse/HDDS-17813
Project: Apache Ozone
Issue Type: Sub-task
Components: Ozone Client, OM
Reporter: Chi-Hsuan Huang
Phase 2 of HDDS-16602 added {{assumeS3Context}} overloads for OM read and write
APIs, but they are declared in different places:
* {{getBucketInfo(volume, bucket, boolean)}} is a {{default}} method on
{{OzoneManagerProtocol}} that ignores the flag. {{OzoneManager}} overrides it.
* {{abortMultipartUpload(OmKeyArgs, boolean)}} is a {{default}} method on
{{OzoneManagerProtocol}} that throws {{UnsupportedOperationException}}.
* {{listParts(..., boolean)}} and {{listMultipartUploads(..., boolean)}}
(HDDS-16698) are declared only on {{OzoneManagerClientProtocol}}.
{{OzoneManager}} has matching public methods that are not part of any interface.
A default that ignores the flag can make a new implementation silently resolve
the wrong volume ([review on PR
#11479|https://github.com/apache/ozone/pull/11479#pullrequestreview-5493327241]).
Without a common shape, each new sub-task picks one of the three by copying
the nearest example.
h3. Proposal
Agree on one placement for upcoming sub-tasks and align the existing overloads.
Declaring the overloads on {{OzoneManagerClientProtocol}} without a default, as
in HDDS-16698, avoids the silent-ignore case. This is open for discussion.
No wire or behavior change is expected.
h3. Related work
* HDDS-16698: [PR #11973|https://github.com/apache/ozone/pull/11973]
* HDDS-16681: [PR #11479|https://github.com/apache/ozone/pull/11479]
* HDDS-16797: [PR #11449|https://github.com/apache/ozone/pull/11449]
* HDDS-17485 also reworks {{abortMultipartUpload}}, so the two may be combined.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]