Copilot commented on code in PR #12063:
URL: https://github.com/apache/ozone/pull/12063#discussion_r4585493418
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/RatisMisReplicationHandler.java:
##########
@@ -62,11 +63,13 @@ protected int sendReplicateCommands(
List<DatanodeDetails> sources, List<DatanodeDetails> targetDns)
throws CommandTargetOverloadedException, NotLeaderException {
ReplicationManager replicationManager = getReplicationManager();
+ StorageType targetStorageType = ReplicationManagerUtil
+ .getTargetStorageType(containerInfo);
int commandsSent = 0;
for (DatanodeDetails target : targetDns) {
replicationManager.sendThrottledReplicationCommand(containerInfo,
- sources, target, 0);
+ sources, target, 0, targetStorageType);
Review Comment:
The RATIS handler tests still stub and verify the four-argument overload, so
`testAllSourcesOverloaded` no longer injects its exception and existing command
verifications fail. Update `TestRatisMisReplicationHandler.java:276,284–285`
and `TestRatisUnderReplicationHandler.java:515–516` to match the five-argument
calls, including the expected destination storage type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]