sadanand48 commented on code in PR #12014:
URL: https://github.com/apache/ozone/pull/12014#discussion_r4586327120
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/diff/MergeJoinSnapDiffWriter.java:
##########
@@ -110,7 +110,7 @@ public static Pair<Long, String>
writeReport(SnapshotDiffManager manager,
}
if (dependencyOrderingEnabledRef[0]) {
long orderStart = Time.monotonicNow();
- orderAndWriteReport(store, nodeCount, reportProgress);
+ dependencyOrderingEnabledRef[0] = orderAndWriteReport(store,
nodeCount, reportProgress);
Review Comment:
In the cycle fallback path, progress appears to remain at 90%. writeReport()
emits FSO_RESOLVE_END_ORDERED before calling orderAndWriteReport(), but when a
cycle is found, the method flushes unordered nodes and returns without
reporting FSO_ORDER_END. updateJobStatusToDone() does not set progress to 100%,
so a successful DONE job may still show 90%. Could we report FSO_ORDER_END
after the fallback flush and extend this test to verify the final callback
value is 1.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]