anuragp010 commented on code in PR #11626:
URL: https://github.com/apache/ozone/pull/11626#discussion_r4589685034
##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/protocol/ClientProtocol.java:
##########
@@ -852,6 +852,24 @@ OmMultipartInfo initiateMultipartUpload(String volumeName,
String
Map<String, String> metadata, Map<String, String> tags)
throws IOException;
+ /**
+ * Initiate Multipart upload.
+ * @param volumeName Name of the Volume
+ * @param bucketName Name of the Bucket
+ * @param keyName Name of the Key
+ * @param replicationConfig Replication config
+ * @param metadata Custom key value metadata
+ * @param tags Tags used for S3 object tags
+ * @param storagePolicy StoragePolicy of the key, or null to inherit the
bucket's
+ * @return {@link OmMultipartInfo}
+ * @throws IOException
+ */
+ OmMultipartInfo initiateMultipartUpload(String volumeName, String
+ bucketName, String keyName, ReplicationConfig replicationConfig,
+ Map<String, String> metadata, Map<String, String> tags,
+ @Nullable StoragePolicy storagePolicy)
Review Comment:
Thanks @rakeshadr for pointing this out. Yes, this is a fair point and the
overloads will keep increasing with every new param. The same applies to the
`createKey` and `createFile` APIs.
I have handled the `initiateMultipartUpload` related changes in this PR.
Will take up the createKey and createFile changes as part of
[HDDS-17839](https://issues.apache.org/jira/browse/HDDS-17839).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]