sodonnel commented on PR #11884: URL: https://github.com/apache/ozone/pull/11884#issuecomment-6927557042
@szetszwo I don't understand the point you are trying to make here. This PR was about reducing memory usage in SCM, where each EC container replica has an EC Replication Config object stored in it, and despite all the objects being logically the same, there are 100's of thousands of instances of them in the worse case. @yandrey321 Has a solution where he pre-computes the finite set of instances and stores them and then offers up the same instance to each replica: > heap retained by 1M ReplicationConfig.fromProto results 30.5 MB 0 MB 32 bytes per object saved There is also a saving in compute to be had as often replication config values are looked up by a string like rs-3-2-1024k, which can have a fixed lookup to the instance against the string, rather than having to split the string and form an object from it. My suggestion, is that I found @yandrey321 approach to be somewhat complex to understand and offered a simpler alternative. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
