adoroszlai commented on code in PR #12055:
URL: https://github.com/apache/ozone/pull/12055#discussion_r4596041965


##########
hadoop-ozone/dist/src/main/smoketest/basic/ozone-shell-lib.robot:
##########
@@ -138,177 +160,244 @@ Test ozone shell errors
 
 Test Volume Acls
     [arguments]     ${protocol}         ${server}       ${volume}
-    Execute         ozone sh volume create ${protocol}${server}/${volume}
-    ${result} =     Execute             ozone sh volume getacl 
${protocol}${server}/${volume}
-    ${acl_check} =  Execute             echo '${result}' | jq -r '.[] | 
select(.type=="USER" and .aclScope=="ACCESS" and (.aclList | 
contains(["ALL"]))) | .name'
-    Should Not Be Empty    ${acl_check}
-    ${result} =     Execute             ozone sh volume addacl 
${protocol}${server}/${volume} -a user:superuser1:rwxy[DEFAULT]
-    ${result} =     Execute             ozone sh volume getacl 
${protocol}${server}/${volume}
-    ${acl_check} =  Execute             echo '${result}' | jq -r '.[] | 
select(.type=="USER" and .name=="superuser1" and .aclScope=="DEFAULT" and 
(.aclList | contains(["READ", "WRITE", "READ_ACL", "WRITE_ACL"]))) | .name'
-    Should Be Equal    ${acl_check}    superuser1
-    ${result} =     Execute             ozone sh volume removeacl 
${protocol}${server}/${volume} -a user:superuser1:xy
-    ${result} =     Execute             ozone sh volume getacl 
${protocol}${server}/${volume}
-    ${acl_check} =  Execute             echo '${result}' | jq -r '.[] | 
select(.type=="USER" and .name=="superuser1" and .aclScope=="DEFAULT" and 
(.aclList | contains(["READ", "WRITE"]))) | .name'
-    Should Be Equal    ${acl_check}    superuser1
-    ${result} =     Execute             ozone sh volume setacl 
${protocol}${server}/${volume} -al 
user:superuser1:rwxy[DEFAULT],group:superuser1:a,user:testuser:rwxyc,group:superuser1:a[DEFAULT]
-    ${result} =     Execute             ozone sh volume getacl 
${protocol}${server}/${volume}
-    ${acl_check} =  Execute             echo '${result}' | jq -r '.[] | 
select(.type=="USER" and .name=="superuser1" and .aclScope=="DEFAULT" and 
(.aclList | contains(["READ", "WRITE", "READ_ACL", "WRITE_ACL"]))) | .name'
-    Should Be Equal    ${acl_check}    superuser1
-    ${acl_check} =  Execute             echo '${result}' | jq -r '.[] | 
select(.type=="GROUP" and .name=="superuser1" and .aclScope=="DEFAULT" and 
(.aclList | contains(["ALL"]))) | .name'
-    Should Be Equal    ${acl_check}    superuser1
+
+    Execute Later ozone sh    volume create ${protocol}${server}/${volume}
+
+    ${result} =     Execute Later ozone sh    volume getacl 
${protocol}${server}/${volume}
+    ${filter} =    Set Variable    jq -r '.[] | select(.type=="USER" and 
.aclScope=="ACCESS" and (.aclList | contains(["ALL"]))) | .name'
+    Assert Later    File ${result} Filtered By ${filter} Should    Not Be 
Equal    ${EMPTY}
+
+    ${result} =     Execute Later ozone sh    volume addacl 
${protocol}${server}/${volume} -a user:superuser1:rwxy[DEFAULT]
+    ${result} =     Execute Later ozone sh    volume getacl 
${protocol}${server}/${volume}
+    ${filter} =    Set Variable    jq -r '.[] | select(.type=="USER" and 
.name=="superuser1" and .aclScope=="DEFAULT" and (.aclList | contains(["READ", 
"WRITE", "READ_ACL", "WRITE_ACL"]))) | .name'
+    Assert Later    File ${result} Filtered By ${filter} Should    Be Equal    
superuser1
+
+    ${result} =     Execute Later ozone sh    volume removeacl 
${protocol}${server}/${volume} -a user:superuser1:xy
+    ${result} =     Execute Later ozone sh    volume getacl 
${protocol}${server}/${volume}
+    ${filter} =    Set Variable    jq -r '.[] | select(.type=="USER" and 
.name=="superuser1" and .aclScope=="DEFAULT" and (.aclList | contains(["READ", 
"WRITE"]))) | .name'
+    Assert Later    File ${result} Filtered By ${filter} Should    Be Equal    
superuser1
+
+    ${result} =     Execute Later ozone sh    volume setacl 
${protocol}${server}/${volume} -al 
user:superuser1:rwxy[DEFAULT],group:superuser1:a,user:testuser:rwxyc,group:superuser1:a[DEFAULT]
+    ${result} =     Execute Later ozone sh    volume getacl 
${protocol}${server}/${volume}
+    ${filter} =    Set Variable    jq -r '.[] | select(.type=="USER" and 
.name=="superuser1" and .aclScope=="DEFAULT" and (.aclList | contains(["READ", 
"WRITE", "READ_ACL", "WRITE_ACL"]))) | .name'
+    Assert Later    File ${result} Filtered By ${filter} Should    Be Equal    
superuser1
+    ${filter} =    Set Variable    jq -r '.[] | select(.type=="GROUP" and 
.name=="superuser1" and .aclScope=="DEFAULT" and (.aclList | 
contains(["ALL"]))) | .name'
+    Assert Later    File ${result} Filtered By ${filter} Should    Be Equal    
superuser1
 
 Test Bucket Acls
     [arguments]     ${protocol}         ${server}       ${volume}
-    Execute         ozone sh bucket create ${protocol}${server}/${volume}/bb1
-    ${result} =     Execute             ozone sh bucket getacl 
${protocol}${server}/${volume}/bb1
-    ${acl_check} =  Execute             echo '${result}' | jq -r '.[] | 
select(.type=="USER" and .aclScope=="ACCESS" and (.aclList | 
contains(["ALL"]))) | .name'
-    Should Not Be Empty    ${acl_check}
-    ${result} =     Execute             ozone sh bucket addacl 
${protocol}${server}/${volume}/bb1 -a user:superuser1:rwxy
-    ${result} =     Execute             ozone sh bucket getacl 
${protocol}${server}/${volume}/bb1
-    ${acl_check} =  Execute             echo '${result}' | jq -r '.[] | 
select(.type=="USER" and .name=="superuser1" and .aclScope=="ACCESS" and 
(.aclList | contains(["READ", "WRITE", "READ_ACL", "WRITE_ACL"]))) | .name'
-    Should Be Equal    ${acl_check}    superuser1
-    ${result} =     Execute             ozone sh bucket removeacl 
${protocol}${server}/${volume}/bb1 -a user:superuser1:xy
-    ${result} =     Execute             ozone sh bucket getacl 
${protocol}${server}/${volume}/bb1
-    ${acl_check} =  Execute             echo '${result}' | jq -r '.[] | 
select(.type=="USER" and .name=="superuser1" and .aclScope=="ACCESS" and 
(.aclList | contains(["READ", "WRITE"]))) | .name'
-    Should Be Equal    ${acl_check}    superuser1
-    ${result} =     Execute             ozone sh bucket setacl 
${protocol}${server}/${volume}/bb1 -al 
user:superuser1:rwxy,group:superuser1:a,user:testuser:rwxyc,group:superuser1:a[DEFAULT]
-    ${result} =     Execute             ozone sh bucket getacl 
${protocol}${server}/${volume}/bb1
-    ${acl_check} =  Execute             echo '${result}' | jq -r '.[] | 
select(.type=="USER" and .name=="superuser1" and .aclScope=="ACCESS" and 
(.aclList | contains(["READ", "WRITE", "READ_ACL", "WRITE_ACL"]))) | .name'
-    Should Be Equal    ${acl_check}    superuser1
-    ${acl_check} =  Execute             echo '${result}' | jq -r '.[] | 
select(.type=="GROUP" and .name=="superuser1" and .aclScope=="DEFAULT" and 
(.aclList | contains(["ALL"]))) | .name'
-    Should Be Equal    ${acl_check}    superuser1
+
+    Execute Later ozone sh    bucket create ${protocol}${server}/${volume}/bb1
+
+    ${result} =     Execute Later ozone sh    bucket getacl 
${protocol}${server}/${volume}/bb1
+    ${filter} =    Set Variable    jq -r '.[] | select(.type=="USER" and 
.aclScope=="ACCESS" and (.aclList | contains(["ALL"]))) | .name'
+    Assert Later    File ${result} Filtered By ${filter} Should    Not Be 
Equal    ${EMPTY}
+
+    ${result} =     Execute Later ozone sh    bucket addacl 
${protocol}${server}/${volume}/bb1 -a user:superuser1:rwxy
+    ${result} =     Execute Later ozone sh    bucket getacl 
${protocol}${server}/${volume}/bb1
+    ${filter} =    Set Variable    jq -r '.[] | select(.type=="USER" and 
.name=="superuser1" and .aclScope=="ACCESS" and (.aclList | contains(["READ", 
"WRITE", "READ_ACL", "WRITE_ACL"]))) | .name'
+    Assert Later    File ${result} Filtered By ${filter} Should    Be Equal    
superuser1
+
+    ${result} =     Execute Later ozone sh    bucket removeacl 
${protocol}${server}/${volume}/bb1 -a user:superuser1:xy
+    ${result} =     Execute Later ozone sh    bucket getacl 
${protocol}${server}/${volume}/bb1
+    ${filter} =    Set Variable    jq -r '.[] | select(.type=="USER" and 
.name=="superuser1" and .aclScope=="ACCESS" and (.aclList | contains(["READ", 
"WRITE"]))) | .name'
+    Assert Later    File ${result} Filtered By ${filter} Should    Be Equal    
superuser1
+
+    ${result} =     Execute Later ozone sh    bucket setacl 
${protocol}${server}/${volume}/bb1 -al 
user:superuser1:rwxy,group:superuser1:a,user:testuser:rwxyc,group:superuser1:a[DEFAULT]
+    ${result} =     Execute Later ozone sh    bucket getacl 
${protocol}${server}/${volume}/bb1
+    ${filter} =    Set Variable    jq -r '.[] | select(.type=="USER" and 
.name=="superuser1" and .aclScope=="ACCESS" and (.aclList | contains(["READ", 
"WRITE", "READ_ACL", "WRITE_ACL"]))) | .name'
+    Assert Later    File ${result} Filtered By ${filter} Should    Be Equal    
superuser1
+
+    ${filter} =    Set Variable    jq -r '.[] | select(.type=="GROUP" and 
.name=="superuser1" and .aclScope=="DEFAULT" and (.aclList | 
contains(["ALL"]))) | .name'
+    Assert Later    File ${result} Filtered By ${filter} Should    Be Equal    
superuser1
 
 Test key handling
     [arguments]     ${protocol}         ${server}       ${volume}
-                    Execute             rm -f /tmp/NOTICE.txt.1 
/tmp/key1_RATIS /tmp/key1-copy
-                    Ozone Shell Batch   key put 
${protocol}${server}/${volume}/bb1/key1 /opt/hadoop/NOTICE.txt
-                    ...                 key get 
${protocol}${server}/${volume}/bb1/key1 /tmp/NOTICE.txt.1
-                    ...                 key put -t RATIS 
${protocol}${server}/${volume}/bb1/key1_RATIS /opt/hadoop/NOTICE.txt
-                    ...                 key get 
${protocol}${server}/${volume}/bb1/key1_RATIS /tmp/key1_RATIS
-                    ...                 key cp 
${protocol}${server}/${volume}/bb1 key1 key1-copy
-                    ...                 key get 
${protocol}${server}/${volume}/bb1/key1-copy /tmp/key1-copy
-                    Execute             diff -q /opt/hadoop/NOTICE.txt 
/tmp/NOTICE.txt.1
-                    Execute             diff -q /opt/hadoop/NOTICE.txt 
/tmp/key1_RATIS
-
-    ${result} =     Execute             ozone sh key info 
${protocol}${server}/${volume}/bb1/key1_RATIS | jq -r '. | 
select(.name=="key1_RATIS")'
-                    Should contain      ${result}       RATIS
-
-                    Execute             diff -q /opt/hadoop/NOTICE.txt 
/tmp/key1-copy
-
-    ${result} =     Execute And Ignore Error    ozone sh key get 
${protocol}${server}/${volume}/bb1/key1 /tmp/NOTICE.txt.1
-                    Should Contain      ${result}       NOTICE.txt.1 exists
-    ${result} =     Execute             ozone sh key get --force 
${protocol}${server}/${volume}/bb1/key1 /tmp/NOTICE.txt.1
-                    Should Not Contain  ${result}       NOTICE.txt.1 exists
-    ${result} =     Execute and checkrc    ozone sh key put 
${protocol}${server}/${volume}/bb1/key1 sample.txt          255
-                    Should Contain         ${result}       File not found: 
sample.txt
-    ${result} =     Execute             ozone sh key info 
${protocol}${server}/${volume}/bb1/key1 | jq -r '. | select(.name=="key1")'
-                    Should contain      ${result}       creationTime
-                    Should not contain  ${result}       ETag
-    ${result} =     Execute             ozone sh key list 
${protocol}${server}/${volume}/bb1 | jq -r '.[] | select(.name=="key1") | .name'
-                    Should Be Equal     ${result}       key1
-                    Execute             ozone sh key rename 
${protocol}${server}/${volume}/bb1 key1 key2
-    ${result} =     Execute             ozone sh key list 
${protocol}${server}/${volume}/bb1 | jq -r '.[] | select(.name=="key2") | .name'
-                    Should Be Equal     ${result}       key2
-                    Ozone Shell Batch   key delete 
${protocol}${server}/${volume}/bb1/key2
-                    ...                 key delete 
${protocol}${server}/${volume}/bb1/key1_RATIS
-                    ...                 key delete 
${protocol}${server}/${volume}/bb1/key1-copy
+
+    Put and Get Key Later    ${protocol}${server}/${volume}/bb1/key1    
put_from=/opt/hadoop/NOTICE.txt
+
+    Execute Later ozone sh    key put -t RATIS 
${protocol}${server}/${volume}/bb1/key1_ratis /opt/hadoop/NOTICE.txt
+    ${file2} =    Get Key Later    
${protocol}${server}/${volume}/bb1/key1_ratis
+    Assert Later    Compare Files    /opt/hadoop/NOTICE.txt    ${file2}
+
+    Execute Later ozone sh    key cp ${protocol}${server}/${volume}/bb1 key1 
key1-copy
+    ${file3} =    Get Key Later    ${protocol}${server}/${volume}/bb1/key1-copy
+    Assert Later    Compare Files    /opt/hadoop/NOTICE.txt    ${file3}
+
+    ${result} =    Execute Later ozone sh    key info 
${protocol}${server}/${volume}/bb1/key1_ratis
+    ${filter} =    Set Variable    jq -r '. | select(.name=="key1_ratis")'
+    Assert Later    File ${result} Filtered By ${filter} Should    Contain    
RATIS
+
+    ${result} =    Execute Later ozone sh    key get 
${protocol}${server}/${volume}/bb1/key1 ${file3}
+    Assert Later    File ${result} Should    Contain    ${file3} exists
+
+    ${result} =    Execute Later ozone sh    key get --force 
${protocol}${server}/${volume}/bb1/key1 ${file3}
+    Assert Later    File ${result} Should    Not Contain    ${file3} exists
+
+    ${result} =    Execute Later ozone sh    key put 
${protocol}${server}/${volume}/bb1/key1 no-such-file
+    Assert Later    File ${result} Should    Contain    File not found: 
no-such-file
+
+    ${result} =    Execute Later ozone sh    key info 
${protocol}${server}/${volume}/bb1/key1
+    ${filter} =    Set Variable    jq -r '. | select(.name=="key1")'
+    Assert Later    File ${result} Filtered By ${filter} Should
+    ...    Contain        creationTime
+    ...    Not Contain    ETag
+
+    ${result} =    Execute Later ozone sh    key list 
${protocol}${server}/${volume}/bb1
+    ${filter} =    Set Variable    jq -r '.[] | select(.name=="key1") | .name'
+    Assert Later    File ${result} Filtered By ${filter} Should    Be Equal    
   key1
+
+    Execute Later ozone sh    key rename ${protocol}${server}/${volume}/bb1 
key1 key2
+    ${result} =     Execute Later ozone sh    key list 
${protocol}${server}/${volume}/bb1
+    ${filter} =    Set Variable    jq -r '.[] | select(.name=="key2") | .name'
+    Assert Later    File ${result} Filtered By ${filter} Should    Be Equal    
   key2
+
+    Execute Later ozone sh    key delete 
${protocol}${server}/${volume}/bb1/key2
+    Execute Later ozone sh    key delete 
${protocol}${server}/${volume}/bb1/key1_ratis
+    Execute Later ozone sh    key delete 
${protocol}${server}/${volume}/bb1/key1-copy
 
 Test key Acls
     [arguments]     ${protocol}         ${server}       ${volume}
-    Execute         ozone sh key put ${protocol}${server}/${volume}/bb1/key2 
/opt/hadoop/NOTICE.txt
-    ${result} =     Execute             ozone sh key getacl 
${protocol}${server}/${volume}/bb1/key2
-    ${acl_check} =  Execute             echo '${result}' | jq -r '.[] | 
select(.type=="USER" and .aclScope=="ACCESS" and (.aclList | 
contains(["ALL"]))) | .name'
-    Should Not Be Empty    ${acl_check}
-    ${result} =     Execute             ozone sh key addacl 
${protocol}${server}/${volume}/bb1/key2 -a user:superuser1:rwxy
-    ${result} =     Execute             ozone sh key getacl 
${protocol}${server}/${volume}/bb1/key2
-    ${acl_check} =  Execute             echo '${result}' | jq -r '.[] | 
select(.type=="USER" and .name=="superuser1" and .aclScope=="ACCESS" and 
(.aclList | contains(["READ", "WRITE", "READ_ACL", "WRITE_ACL"]))) | .name'
-    Should Be Equal    ${acl_check}    superuser1
-    ${result} =     Execute             ozone sh key removeacl 
${protocol}${server}/${volume}/bb1/key2 -a user:superuser1:xy
-    ${result} =     Execute             ozone sh key getacl 
${protocol}${server}/${volume}/bb1/key2
-    ${acl_check} =  Execute             echo '${result}' | jq -r '.[] | 
select(.type=="USER" and .name=="superuser1" and .aclScope=="ACCESS" and 
(.aclList | contains(["READ", "WRITE"]))) | .name'
-    Should Be Equal    ${acl_check}    superuser1
-    ${result} =     Execute             ozone sh key setacl 
${protocol}${server}/${volume}/bb1/key2 -al 
user:superuser1:rwxy,group:superuser1:a,user:testuser:rwxyc
-    ${result} =     Execute             ozone sh key getacl 
${protocol}${server}/${volume}/bb1/key2
-    ${acl_check} =  Execute             echo '${result}' | jq -r '.[] | 
select(.type=="USER" and .name=="superuser1" and .aclScope=="ACCESS" and 
(.aclList | contains(["READ", "WRITE", "READ_ACL", "WRITE_ACL"]))) | .name'
-    Should Be Equal    ${acl_check}    superuser1
-    ${acl_check} =  Execute             echo '${result}' | jq -r '.[] | 
select(.type=="GROUP" and .name=="superuser1" and .aclScope=="ACCESS" and 
(.aclList | contains(["ALL"]))) | .name'
-    Should Be Equal    ${acl_check}    superuser1
+
+    Execute Later ozone sh    key put ${protocol}${server}/${volume}/bb1/key2 
/opt/hadoop/NOTICE.txt
+
+    ${result} =     Execute Later ozone sh    key getacl 
${protocol}${server}/${volume}/bb1/key2
+    ${filter} =    Set Variable    jq -r '.[] | select(.type=="USER" and 
.aclScope=="ACCESS" and (.aclList | contains(["ALL"]))) | .name'
+    Assert Later    File ${result} Filtered By ${filter} Should    Not Be 
Equal    ${EMPTY}
+
+    ${result} =     Execute Later ozone sh    key addacl 
${protocol}${server}/${volume}/bb1/key2 -a user:superuser1:rwxy
+    ${result} =     Execute Later ozone sh    key getacl 
${protocol}${server}/${volume}/bb1/key2
+    ${filter} =    Set Variable    jq -r '.[] | select(.type=="USER" and 
.name=="superuser1" and .aclScope=="ACCESS" and (.aclList | contains(["READ", 
"WRITE", "READ_ACL", "WRITE_ACL"]))) | .name'
+    Assert Later    File ${result} Filtered By ${filter} Should    Be Equal    
superuser1
+
+    ${result} =     Execute Later ozone sh    key removeacl 
${protocol}${server}/${volume}/bb1/key2 -a user:superuser1:xy
+    ${result} =     Execute Later ozone sh    key getacl 
${protocol}${server}/${volume}/bb1/key2
+    ${filter} =    Set Variable    jq -r '.[] | select(.type=="USER" and 
.name=="superuser1" and .aclScope=="ACCESS" and (.aclList | contains(["READ", 
"WRITE"]))) | .name'
+    Assert Later    File ${result} Filtered By ${filter} Should    Be Equal    
superuser1
+
+    ${result} =     Execute Later ozone sh    key setacl 
${protocol}${server}/${volume}/bb1/key2 -al 
user:superuser1:rwxy,group:superuser1:a,user:testuser:rwxyc
+    ${result} =     Execute Later ozone sh    key getacl 
${protocol}${server}/${volume}/bb1/key2
+    ${filter} =    Set Variable    jq -r '.[] | select(.type=="USER" and 
.name=="superuser1" and .aclScope=="ACCESS" and (.aclList | contains(["READ", 
"WRITE", "READ_ACL", "WRITE_ACL"]))) | .name'
+    Assert Later    File ${result} Filtered By ${filter} Should    Be Equal    
superuser1
+
+    ${filter} =    Set Variable    jq -r '.[] | select(.type=="GROUP" and 
.name=="superuser1" and .aclScope=="ACCESS" and (.aclList | contains(["ALL"]))) 
| .name'
+    Assert Later    File ${result} Filtered By ${filter} Should    Be Equal    
superuser1
 
 Test prefix Acls
     [arguments]     ${protocol}         ${server}       ${volume}
-    Execute         ozone sh prefix addacl 
${protocol}${server}/${volume}/bb1/prefix1/ -a user:superuser1:rwxy[DEFAULT]
-    ${result} =     Execute             ozone sh prefix getacl 
${protocol}${server}/${volume}/bb1/prefix1/
-    ${acl_check} =  Execute             echo '${result}' | jq -r '.[] | 
select(.type=="USER" and .name=="superuser1" and .aclScope=="DEFAULT" and 
(.aclList | contains(["READ", "WRITE", "READ_ACL", "WRITE_ACL"]))) | .name'
-    Should Be Equal    ${acl_check}    superuser1
-    ${result} =     Execute             ozone sh prefix removeacl 
${protocol}${server}/${volume}/bb1/prefix1/ -a user:superuser1:xy
-    ${result} =     Execute             ozone sh prefix getacl 
${protocol}${server}/${volume}/bb1/prefix1/
-    ${acl_check} =  Execute             echo '${result}' | jq -r '.[] | 
select(.type=="USER" and .name=="superuser1" and .aclScope=="DEFAULT" and 
(.aclList | contains(["READ", "WRITE"]))) | .name'
-    Should Be Equal    ${acl_check}    superuser1
-    ${result} =     Execute             ozone sh prefix setacl 
${protocol}${server}/${volume}/bb1/prefix1/ -al 
user:superuser1:rwxy[DEFAULT],group:superuser1:a[DEFAULT],user:testuser:rwxyc
-    ${result} =     Execute             ozone sh prefix getacl 
${protocol}${server}/${volume}/bb1/prefix1/
-    ${acl_check} =  Execute             echo '${result}' | jq -r '.[] | 
select(.type=="USER" and .name=="superuser1" and .aclScope=="DEFAULT" and 
(.aclList | contains(["READ", "WRITE", "READ_ACL", "WRITE_ACL"]))) | .name'
-    Should Be Equal    ${acl_check}    superuser1
-    ${acl_check} =  Execute             echo '${result}' | jq -r '.[] | 
select(.type=="GROUP" and .name=="superuser1" and .aclScope=="DEFAULT" and 
(.aclList | contains(["ALL"]))) | .name'
-    Should Be Equal    ${acl_check}    superuser1
-    Execute         ozone sh key put 
${protocol}${server}/${volume}/bb1/prefix1/key1 /opt/hadoop/NOTICE.txt
-    ${result} =     Execute             ozone sh key getacl 
${protocol}${server}/${volume}/bb1/prefix1/key1
-    ${acl_check} =  Execute             echo '${result}' | jq -r '.[] | 
select(.type=="USER" and .name=="superuser1" and .aclScope=="ACCESS" and 
(.aclList | contains(["READ", "WRITE", "READ_ACL", "WRITE_ACL"]))) | .name'
-    Should Be Equal    ${acl_check}    superuser1
-    ${acl_check} =  Execute             echo '${result}' | jq -r '.[] | 
select(.type=="GROUP" and .name=="superuser1" and .aclScope=="ACCESS" and 
(.aclList | contains(["ALL"]))) | .name'
-    Should Be Equal    ${acl_check}    superuser1
+
+    Execute Later ozone sh    prefix addacl 
${protocol}${server}/${volume}/bb1/prefix1/ -a user:superuser1:rwxy[DEFAULT]
+
+    ${result} =     Execute Later ozone sh    prefix getacl 
${protocol}${server}/${volume}/bb1/prefix1/
+    ${filter} =    Set Variable    jq -r '.[] | select(.type=="USER" and 
.name=="superuser1" and .aclScope=="DEFAULT" and (.aclList | contains(["READ", 
"WRITE", "READ_ACL", "WRITE_ACL"]))) | .name'
+    Assert Later    File ${result} Filtered By ${filter} Should    Be Equal    
superuser1
+
+    ${result} =     Execute Later ozone sh    prefix removeacl 
${protocol}${server}/${volume}/bb1/prefix1/ -a user:superuser1:xy
+    ${result} =     Execute Later ozone sh    prefix getacl 
${protocol}${server}/${volume}/bb1/prefix1/
+    ${filter} =    Set Variable    jq -r '.[] | select(.type=="USER" and 
.name=="superuser1" and .aclScope=="DEFAULT" and (.aclList | contains(["READ", 
"WRITE"]))) | .name'
+    Assert Later    File ${result} Filtered By ${filter} Should    Be Equal    
superuser1
+
+    ${result} =     Execute Later ozone sh    prefix setacl 
${protocol}${server}/${volume}/bb1/prefix1/ -al 
user:superuser1:rwxy[DEFAULT],group:superuser1:a[DEFAULT],user:testuser:rwxyc
+    ${result} =     Execute Later ozone sh    prefix getacl 
${protocol}${server}/${volume}/bb1/prefix1/
+    ${filter} =    Set Variable    jq -r '.[] | select(.type=="USER" and 
.name=="superuser1" and .aclScope=="DEFAULT" and (.aclList | contains(["READ", 
"WRITE", "READ_ACL", "WRITE_ACL"]))) | .name'
+    Assert Later    File ${result} Filtered By ${filter} Should    Be Equal    
superuser1
+
+    ${filter} =    Set Variable    jq -r '.[] | select(.type=="GROUP" and 
.name=="superuser1" and .aclScope=="DEFAULT" and (.aclList | 
contains(["ALL"]))) | .name'
+    Assert Later    File ${result} Filtered By ${filter} Should    Be Equal    
superuser1
+
+    Execute Later ozone sh    key put 
${protocol}${server}/${volume}/bb1/prefix1/key1 /opt/hadoop/NOTICE.txt
+    ${result} =     Execute Later ozone sh    key getacl 
${protocol}${server}/${volume}/bb1/prefix1/key1
+    ${filter} =    Set Variable    jq -r '.[] | select(.type=="USER" and 
.name=="superuser1" and .aclScope=="ACCESS" and (.aclList | contains(["READ", 
"WRITE", "READ_ACL", "WRITE_ACL"]))) | .name'
+    Assert Later    File ${result} Filtered By ${filter} Should    Be Equal    
superuser1
+
+    ${filter} =    Set Variable    jq -r '.[] | select(.type=="GROUP" and 
.name=="superuser1" and .aclScope=="ACCESS" and (.aclList | contains(["ALL"]))) 
| .name'
+    Assert Later    File ${result} Filtered By ${filter} Should    Be Equal    
superuser1
 
 Test native authorizer
     [arguments]     ${protocol}         ${server}       ${volume}
 
     Return From Keyword if    '${SECURITY_ENABLED}' == 'false'
 
-    Execute         ozone sh volume removeacl ${protocol}${server}/${volume} 
-a group:root:a
-    Execute         kdestroy
-    Run Keyword     Kinit test user     testuser2    testuser2.keytab
-    ${result} =     Execute And Ignore Error         ozone sh bucket list 
${protocol}${server}/${volume}
-                    Should contain      ${result}    PERMISSION_DENIED
-    ${result} =     Execute And Ignore Error         ozone sh key list 
${protocol}${server}/${volume}/bb1
-                    Should contain      ${result}    PERMISSION_DENIED
-    ${result} =     Execute And Ignore Error         ozone sh volume addacl 
${protocol}${server}/${volume} -a user:testuser2:xy
-                    Should contain      ${result}    PERMISSION_DENIED User 
testuser2 doesn't have WRITE_ACL permission to access volume
-    Execute         kdestroy
-    Run Keyword     Kinit test user     testuser     testuser.keytab
-    Execute         ozone sh volume addacl ${protocol}${server}/${volume} -a 
user:testuser2:xyrw
-    Execute         kdestroy
-    Run Keyword     Kinit test user     testuser2    testuser2.keytab
-    ${result} =     Execute And Ignore Error         ozone sh bucket list 
${protocol}${server}/${volume}
-                    Should contain      ${result}    PERMISSION_DENIED User 
testuser2 doesn't have LIST permission to access volume
-    Execute         ozone sh volume addacl ${protocol}${server}/${volume} -a 
user:testuser2:l
-    Execute         ozone sh bucket list ${protocol}${server}/${volume}
-    Execute         ozone sh volume getacl ${protocol}${server}/${volume}
-
-    ${result} =     Execute And Ignore Error         ozone sh key list 
${protocol}${server}/${volume}/bb1
-    Should contain      ${result}    PERMISSION_DENIED
-    Execute         kdestroy
-    Run Keyword     Kinit test user     testuser     testuser.keytab
-    Execute         ozone sh bucket addacl ${protocol}${server}/${volume}/bb1 
-a user:testuser2:a
-    Execute         ozone sh bucket getacl ${protocol}${server}/${volume}/bb1
+    # setup with testuser
+
+    ${expected} =    Get test user principal    testuser
+    Should Be Equal    ${TEST_USER}    ${expected}
+
+    # no access
+    ${vol1} =    Set Variable    ${protocol}${server}/${volume}1
+    Execute Later ozone sh    volume create ${vol1}
+    Execute Later ozone sh    volume removeacl ${vol1} -a group:root:a
+
+    # no list
+    ${vol2} =    Set Variable    ${protocol}${server}/${volume}2
+    Execute Later ozone sh    volume create ${vol2}
+    Execute Later ozone sh    volume removeacl ${vol2} -a group:root:a
+    Execute Later ozone sh    volume addacl ${vol2} -a user:testuser2:xyrw
+    Execute Later ozone sh    bucket create ${vol2}/bb1
+
+    # all access to bucket
+    ${vol3} =    Set Variable    ${protocol}${server}/${volume}3
+    Execute Later ozone sh    volume create ${vol3}
+    Execute Later ozone sh    volume removeacl ${vol3} -a group:root:a
+    Execute Later ozone sh    volume addacl ${vol3} -a user:testuser2:xyrw
+    Execute Later ozone sh    bucket create ${vol3}/bb1
+    Execute Later ozone sh    bucket addacl ${vol3}/bb1 -a user:testuser2:a
+
+    Execute Batch
+
+    # tests with testuser2
+
     Execute         kdestroy
-    Run Keyword     Kinit test user     testuser2    testuser2.keytab
-    Execute         ozone sh bucket getacl ${protocol}${server}/${volume}/bb1
-    Execute         ozone sh key list ${protocol}${server}/${volume}/bb1
+    Kinit test user     testuser2    testuser2.keytab
+
+    # no access
+    ${result} =     Execute Later ozone sh    bucket list ${vol1}
+    Assert Later    File ${result} Should    Contain    PERMISSION_DENIED
+    ${result} =     Execute Later ozone sh    key list ${vol1}/bb1
+    Assert Later    File ${result} Should    Contain    PERMISSION_DENIED
+    ${result} =     Execute Later ozone sh    volume addacl ${vol1} -a 
user:testuser2:xy
+    Assert Later    File ${result} Should    Contain    PERMISSION_DENIED User 
testuser2 doesn't have WRITE_ACL permission to access volume
+
+    # no list
+    ${result} =     Execute Later ozone sh    bucket list ${vol2}
+    Assert Later    File ${result} Should    Contain    PERMISSION_DENIED User 
testuser2 doesn't have LIST permission to access volume
+    ${result} =     Execute Later ozone sh    volume addacl ${vol2} -a 
user:testuser2:l
+    Assert Later    File ${result} Should    Not Contain    PERMISSION_DENIED
+    ${result} =     Execute Later ozone sh    bucket list ${vol2}
+    Assert Later    File ${result} Should    Not Contain    PERMISSION_DENIED
+    ${result} =     Execute Later ozone sh    volume getacl ${vol2}
+    Assert Later    File ${result} Should    Not Contain    PERMISSION_DENIED
+    ${result} =     Execute Later ozone sh    key list ${vol2}/bb1
+    Assert Later    File ${result} Should    Contain    PERMISSION_DENIED
+
+    # all access to bucket
+    ${result} =     Execute Later ozone sh    bucket getacl ${vol3}/bb1
+    Assert Later    File ${result} Should    Not Contain    PERMISSION_DENIED
+    ${result} =     Execute Later ozone sh    key list ${vol3}/bb1
+    Assert Later    File ${result} Should    Not Contain    PERMISSION_DENIED
+
+    Execute Batch
     Execute         kdestroy
-    Run Keyword     Kinit test user     testuser    testuser.keytab
+
 
 Test Delete key with Trash
     [arguments]    ${protocol}         ${server}       ${volume}
-                   Ozone Shell Batch     volume create 
${protocol}${server}/${volume}
-                   ...                   bucket create 
${protocol}${server}/${volume}/bfso --layout FILE_SYSTEM_OPTIMIZED
-                   ...                   key put -t RATIS 
${protocol}${server}/${volume}/bfso/key3 /opt/hadoop/NOTICE.txt
-                   ...                   key delete 
${protocol}${server}/${volume}/bfso/key3
-    ${fsokey} =    Execute               ozone sh key list 
${protocol}${server}/${volume}/bfso
-    ${result} =    Execute               echo '${fsokey}' | jq -r '.[] | 
select(.name | startswith(".Trash")) | .name'
-                   Should Contain Any    ${result}    .Trash/hadoop    
.Trash/testuser    .Trash/root
-                   Should contain        ${result}    key3
-    ${result} =    Execute               echo '${fsokey}' | jq -r '.[] | 
select(.name | startswith(".Trash") | not) | .name'
-                   Should Not contain    ${result}    key3
-                   Ozone Shell Batch     bucket create 
${protocol}${server}/${volume}/obsbkt --layout OBJECT_STORE
-                   ...                   key put -t RATIS 
${protocol}${server}/${volume}/obsbkt/key2 /opt/hadoop/NOTICE.txt
-                   ...                   key delete 
${protocol}${server}/${volume}/obsbkt/key2
-    ${result} =    Execute               ozone sh key list 
${protocol}${server}/${volume}/obsbkt
-                   Should not contain    ${result}    key2
+
+    Execute Later ozone sh    volume create ${protocol}${server}/${volume}
+    Execute Later ozone sh    bucket create 
${protocol}${server}/${volume}/bfso --layout FILE_SYSTEM_OPTIMIZED
+    Execute Later ozone sh    key put -t RATIS 
${protocol}${server}/${volume}/bfso/key3 /opt/hadoop/NOTICE.txt
+    Execute Later ozone sh    key delete 
${protocol}${server}/${volume}/bfso/key3
+
+    ${result} =    Execute Later ozone sh    key list 
${protocol}${server}/${volume}/bfso
+    ${filter} =    Set Variable    jq -r '.[] | select(.name | 
startswith(".Trash")) | .name'
+    Assert Later    File ${result} Filtered By ${filter} Should    Contain     
     key3
+
+    ${filter} =    Set Variable    jq -r '.[] | select(.name | 
startswith(".Trash") | not) | .name'
+    Assert Later    File ${result} Filtered By ${filter} Should    Not contain 
     key3
+
+    Execute Later ozone sh    bucket create 
${protocol}${server}/${volume}/obsbkt --layout OBJECT_STORE
+    Execute Later ozone sh    key put -t RATIS 
${protocol}${server}/${volume}/obsbkt/key2 /opt/hadoop/NOTICE.txt
+    Execute Later ozone sh    key delete 
${protocol}${server}/${volume}/obsbkt/key2
+
+    ${result} =    Execute Later ozone sh    key list 
${protocol}${server}/${volume}/obsbkt
+    Assert Later    File ${result} Filtered By ${filter} Should    not contain 
     key2

Review Comment:
   Thanks, `${filter}` should not be used here, updated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to