devmadhuu commented on code in PR #11965:
URL: https://github.com/apache/ozone/pull/11965#discussion_r4596496484


##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerService.java:
##########
@@ -544,6 +544,12 @@ public BackgroundTaskResult call() {
           LOG.warn("Container {} is in {} state, skipping move process.", 
containerId, containerState);
           return BackgroundTaskResult.EmptyTaskResult.newResult();
         }
+        if (sourceVolume.getStorageType() != destVolume.getStorageType()) {
+          LOG.warn("Container {}: Source volume storage type ({}) differs from 
destination volume storage type ({}). "
+                  + "Skipping the disk balancing move.",
+              containerId, sourceVolume.getStorageType(), 
destVolume.getStorageType());
+          return BackgroundTaskResult.EmptyTaskResult.newResult();
+        }

Review Comment:
   Yeah, good point. This can be rejected even before creating a task. I have 
moved it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to