adoroszlai commented on code in PR #12067:
URL: https://github.com/apache/ozone/pull/12067#discussion_r4597296637
##########
hadoop-hdds/pom.xml:
##########
@@ -38,12 +38,12 @@
<module>erasurecode</module>
<module>framework</module>
<module>hadoop-dependency-client</module>
+ <module>hdds-rocksdb-checkpoint-differ</module>
<module>interface-admin</module>
<module>interface-client</module>
<module>interface-server</module>
<module>managed-rocksdb</module>
<module>rocks-native</module>
- <module>rocksdb-checkpoint-differ</module>
Review Comment:
Module directories do not have `hdds-` prefix, we should follow that for
`rocksdb-checkpoint-differ`, too.
##########
hadoop-ozone/dev-support/checks/coverage.sh:
##########
@@ -51,6 +51,7 @@ find hadoop-ozone/dist/target/*/share/ozone/lib -name
'hdds-*.jar' -or -name 'oz
#Exclude some classes from the coverage
find target/coverage-classes -type d \( -name proto -or -name codegen -or
-name generated -or -name v1 -or -name freon \) \
| xargs rm -rf
+rm -rf target/coverage-classes/org/apache/hadoop/ipc_/protobuf
Review Comment:
Let's not hard-code the path here.
```suggestion
find target/coverage-classes -type d \( -name proto -or -name protobuf -or
-name codegen -or -name generated -or -name freon \) \
| xargs rm -rf
```
- `v1` can be dropped, because it was part of `ozone-csi`, removed in
HDDS-15876.
- Let's also remove `freon` to more closely reflect what Sonar reports. We
also do have some tests for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]