chihsuan commented on code in PR #12070:
URL: https://github.com/apache/ozone/pull/12070#discussion_r4602299662


##########
.github/workflows/build-ratis.yml:
##########
@@ -126,9 +126,9 @@ jobs:
       - name: Get component versions
         id: versions
         run: |
-          echo "grpc=$(mvn help:evaluate -N -q -DforceStdout -Dscan=false 
-Dexpression=shaded.grpc.version)" >> $GITHUB_OUTPUT
-          echo "netty=$(mvn help:evaluate -N -q -DforceStdout -Dscan=false 
-Dexpression=shaded.netty.version)" >> $GITHUB_OUTPUT
-          echo "protobuf=$(mvn help:evaluate -N -q -DforceStdout -Dscan=false 
-Dexpression=shaded.protobuf.version)" >> $GITHUB_OUTPUT
+          echo "grpc=$(./mvnw help:evaluate -N -q -DforceStdout -Dscan=false 
-Dexpression=shaded.grpc.version)" >> $GITHUB_OUTPUT
+          echo "netty=$(./mvnw help:evaluate -N -q -DforceStdout -Dscan=false 
-Dexpression=shaded.netty.version)" >> $GITHUB_OUTPUT
+          echo "protobuf=$(./mvnw help:evaluate -N -q -DforceStdout 
-Dscan=false -Dexpression=shaded.protobuf.version)" >> $GITHUB_OUTPUT

Review Comment:
   Looks like this runs in the `ratis-thirdparty` checkout. Should we keep 
`mvn` here, or every ratis-thirdparty we check out here have `mvnw`?



##########
hadoop-ozone/dev-support/checks/acceptance.sh:
##########
@@ -26,21 +26,21 @@ OZONE_ROOT=$(pwd -P)
 : ${OZONE_ACCEPTANCE_TEST_TYPE:="robot"}
 : ${OZONE_WITH_COVERAGE:="false"}
 
+source "${DIR}/_lib.sh"
+
 if [[ "${OZONE_TEST_SELECTOR}" == "xcompat/test-old.sh" ]]; then
   : ${OZONE_OLD_VERSIONS:="${2:-}"}
   export OZONE_OLD_VERSIONS
 
   # use JDK8 image for Rebot in compat-old, to avoid pulling JDK25 image just 
for generating reports
   # TODO after HDDS-17509 this can be moved to env: of compat-old job
-  export OZONE_RUNNER_VERSION=$(mvn help:evaluate -pl :ozone-dist 
-Dexpression="docker.ozone-runner.client.version" -q -DforceStdout -Dscan=false)
+  export OZONE_RUNNER_VERSION=$(get_version "docker.ozone-runner.client" -pl 
:ozone-dist)

Review Comment:
   Should this use `-f` instead of `-pl :ozone-dist`? With `--non-recursive`, 
this returns a Maven error instead of the version, and `compat-old` lost its 
robot results 
([log](https://github.com/adoroszlai/ozone/actions/runs/43958031996/job/133639218947#step:16:328)).
 
   
   ```suggestion
     export OZONE_RUNNER_VERSION=$(get_version "docker.ozone-runner.client" -f 
hadoop-ozone/dist)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to