JacksonYao287 commented on a change in pull request #2488:
URL: https://github.com/apache/ozone/pull/2488#discussion_r686887254
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ReplicationManager.java
##########
@@ -1712,8 +1745,244 @@ public ReplicationManagerMetrics getMetrics() {
return inflightDeletion;
}
- public Map<ContainerID,
- Pair<DatanodeDetails, DatanodeDetails>> getInflightMove() {
- return inflightMove;
+ public Map<ContainerID, CompletableFuture<MoveResult>> getInflightMove() {
+ return inflightMoveFuture;
+ }
+
+ /**
+ * make move option HA aware.
+ */
+ public interface MoveScheduler {
Review comment:
yea, sure, but considering they are small and simple, and only be used
in replication manager (we also do not want it is used in other places), so i
think it is better off keeping it inside replicationManager for now .
refactoring is easy if needed in the future. what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
