priyeshkaratha commented on PR #11932:
URL: https://github.com/apache/ozone/pull/11932#issuecomment-6968037487
> 1. Will this tab display the linked buckets also ? Hope it is not
duplicated ?
Its not duplicated and I have verified it.
> 2. `Calculate` button does not just compute the snapshot trapped bytes , I
think it computes the number of snapshot trapped keys and snapshot trapped
directories as well, so message and header title on popup is misleading.
Agreed. The popup title, its description and the error message now say that
the calculation covers the snapshot trapped and purgeable bytes, keys and
directories. The Snapshot Trapped Bytes column tooltip is updated the same way.
> 3. Values for getting `Purgeable Bytes, Purgeable Keys and Purgeable
Directories` is not an expensive operation, they should already be available
pre-computed in Recon by `NSSummary`, can you check ? If yes, then shouldn't
the snapshot trapped metadata be easily computable ? We should be able to
display even when user has not clicked the `Calculate` button.
NSSummary cannot provide these values. It only tracks the file counts, sizes
and children of the active namespace. Splitting the deleted data into purgeable
and snapshot trapped needs each deleted entry to be checked against every
snapshot of the bucket.
> 4. Even with any error on `Calculate` by the job, is re-calculate
retry-able ? Because snapshot trapped related metadata can change over time and
user may want to see latest values point in time.
Yes, both work. A failed calculation shows a Failed tag with the error as a
tooltip and a Retry button. A completed one shows the time it was calculated
and a Recalculate button, so the user can get the latest values at any time.
> 5. Search for a specific bucket using volume/bucket path in search box is
global across all pages or just a local search on UI for that page only ? If it
is just local for the displayed page, then it is not meaningful, it should be
global search.
You are right, it was only filtering the fetched page. Recon now does the
search: the search term is sent as startPrefix to
/api/v1/keys/deletePending/buckets and applied before the limit. A bucket
outside the largest ones fetched is still found. I also added tests for this in
both the UI and the endpoint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]