aayush2761 commented on code in PR #12053:
URL: https://github.com/apache/ozone/pull/12053#discussion_r4633345209
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java:
##########
@@ -1467,12 +1467,13 @@ public void markContainerForClose(Container container)
container.getContainerState();
// Move the container to CLOSING state only if it's OPEN/RECOVERING
if (HddsUtils.isOpenToWriteState(state)) {
- if (state == RECOVERING) {
+ boolean wasRecovering = state == RECOVERING;
+ container.markContainerForClose();
+ if (wasRecovering) {
Review Comment:
addressed, Thanks!
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java:
##########
@@ -1467,12 +1467,13 @@ public void markContainerForClose(Container container)
container.getContainerState();
// Move the container to CLOSING state only if it's OPEN/RECOVERING
if (HddsUtils.isOpenToWriteState(state)) {
- if (state == RECOVERING) {
+ boolean wasRecovering = state == RECOVERING;
+ container.markContainerForClose();
+ if (wasRecovering) {
containerSet.removeRecoveringContainer(
container.getContainerData().getContainerID());
ContainerLogger.logRecovered(container.getContainerData());
Review Comment:
addressed, Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]