Gargi-jais11 commented on code in PR #12094:
URL: https://github.com/apache/ozone/pull/12094#discussion_r4639285474
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/MultiDeleteRequestUnmarshaller.java:
##########
@@ -35,4 +48,20 @@ public MultiDeleteRequestUnmarshaller() {
super(MultiDeleteRequest.class);
}
+ @Override
+ public MultiDeleteRequest readFrom(Class<MultiDeleteRequest> clazz, Type
type, Annotation[] annotations,
+ MediaType mediaType, MultivaluedMap<String, String> httpHeaders,
InputStream inputStream)
+ throws WebApplicationException {
+ final byte[] body;
+ try {
+ body = IOUtils.toByteArray(inputStream);
Review Comment:
Not very sure of it as AWS publishes no body-size limit for DeleteObjects,
only the 1000-key limit is there.
However, AWS itself uses `MaxMessageLengthExceeded` for oversized requests,
so a new error entry would match AWS more closely but adds to the change.
and if we bound than how much should be the size of array ? I was thinking
of keeping it as 8 MiB since it fits 1000 keys of the maximum 1024 bytes even
with heavy XML escaping, so no valid request should hit it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]