adoroszlai commented on code in PR #12102:
URL: https://github.com/apache/ozone/pull/12102#discussion_r4639563772


##########
hadoop-ozone/dist/src/main/smoketest/security/ozone-secure-sts.robot:
##########
@@ -743,11 +743,13 @@ Assume Role Should Fail For Too Short Role Session Name
 
 Assume Role Should Fail For Invalid Duration
     # AWS CLI rejects out-of-range DurationSeconds before the request is sent, 
so use curl.

Review Comment:
   This is what I meant by "need to find a way to make the request without 
client-side validation" (in the task).  I didn't know it already exists.



##########
hadoop-ozone/integration-test-full-deps/src/test/java/org/apache/hadoop/ozone/TestOzoneConfigurationFields.java:
##########
@@ -135,6 +135,7 @@ private void addPropertiesNotInXml() {
         HddsConfigKeys.HDDS_CONTAINER_PERSISTDATA,
         HddsConfigKeys.HDDS_GRPC_TLS_TEST_CERT,
         HddsConfigKeys.HDDS_X509_GRACE_DURATION_TOKEN_CHECKS_ENABLED,
+        OzoneConfigKeys.OZONE_S3G_STS_TEST_MIN_DURATION_SECONDS_KEY,

Review Comment:
   This can be removed if key is moved to `S3STSUtils`.



##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConfigKeys.java:
##########
@@ -740,6 +740,12 @@ public final class OzoneConfigKeys {
       "ozone.s3g.sts.http.enabled";
   public static final boolean OZONE_S3G_STS_HTTP_ENABLED_DEFAULT = false;
 
+  /**
+   * Test-only: override the minimum AssumeRole {@code DurationSeconds} 
accepted by OM and S3 Gateway STS.
+   * Values may only lower the AWS-compatible minimum of 900 seconds.  Valid 
range is 1-900.
+   */
+  public static final String OZONE_S3G_STS_TEST_MIN_DURATION_SECONDS_KEY = 
"ozone.s3g.sts.test.min.duration.seconds";
+

Review Comment:
   I would move this hidden config key to `S3STSUtils`:
   - avoid unnecessary change in `hdds-common`
   - no need to add XML exception in `TestOzoneConfigurationFields`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to