vivekratnavel commented on pull request #2530: URL: https://github.com/apache/ozone/pull/2530#issuecomment-899688874
@yuangu002 Great job! Thanks for the demo video. Overall looks good to me. Just a couple of items to remember to improve the user experience: - Rename "< Back" button to just "<" or "< Previous" to avoid confusion with browser back button behavior and make it disabled at the first visit when there is no history. - Make the [display limit](https://github.com/apache/ozone/pull/2530/files#diff-4d9ddef7873bb3ee5f89fd7b50f68cc78eef723e37a764c16d6ef8c723ed2bcdR28) configurable in UI with a dropdown (5, 10, 15, 20, All). Then we should make the default be 10 since I think even 20 will be clunky. Both of these items can be tracked separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
