sodonnel commented on a change in pull request #2507: URL: https://github.com/apache/ozone/pull/2507#discussion_r691158647
########## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/read/TestECBlockInputStream.java ########## @@ -0,0 +1,405 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.ozone.client.rpc.read; + +import org.apache.hadoop.hdds.client.BlockID; +import org.apache.hadoop.hdds.client.ECReplicationConfig; +import org.apache.hadoop.hdds.client.ReplicationConfig; +import org.apache.hadoop.hdds.protocol.DatanodeDetails; +import org.apache.hadoop.hdds.protocol.MockDatanodeDetails; +import org.apache.hadoop.hdds.scm.XceiverClientFactory; +import org.apache.hadoop.hdds.scm.pipeline.Pipeline; +import org.apache.hadoop.hdds.scm.pipeline.PipelineID; +import org.apache.hadoop.hdds.scm.storage.BlockInputStream; +import org.apache.hadoop.hdds.security.token.OzoneBlockTokenIdentifier; +import org.apache.hadoop.ozone.client.io.BlockInputStreamFactory; +import org.apache.hadoop.ozone.client.io.ECBlockInputStream; +import org.apache.hadoop.ozone.om.helpers.OmKeyLocationInfo; +import org.apache.hadoop.security.token.Token; +import org.junit.Assert; +import org.junit.Test; + +import java.io.IOException; +import java.nio.ByteBuffer; +import java.util.ArrayList; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.function.Function; + +/** + * Tests for ECBlockInputStream. + */ +public class TestECBlockInputStream { + + private static final int ONEMB = 1024 * 1024; + + @Test + // TODO - this test will need changed when we can do recovery reads. + public void testSufficientLocations() { + ECReplicationConfig repConfig = new ECReplicationConfig(3, 2); + + // EC-3-2, 5MB block, so all 3 data locations are needed + OmKeyLocationInfo keyInfo = createKeyInfo(repConfig, 5, 5 * ONEMB); + ECBlockInputStream ecb = new ECBlockInputStream(repConfig, ONEMB, + keyInfo, true, new TestBlockInputStreamFactory()); + Assert.assertTrue(ecb.hasSufficientLocations()); + ecb.close(); + + // EC-3-2, very large block, so all 3 data locations are needed + keyInfo = createKeyInfo(repConfig, 5, 5000 * ONEMB); + ecb = new ECBlockInputStream(repConfig, ONEMB, + keyInfo, true, new TestBlockInputStreamFactory()); + Assert.assertTrue(ecb.hasSufficientLocations()); + ecb.close(); + + Map<DatanodeDetails, Integer> dnMap = new HashMap<>(); + + // EC-3-2, 1 byte short of 1MB with 1 location + dnMap.clear(); + dnMap.put(MockDatanodeDetails.randomDatanodeDetails(), 1); + keyInfo = createKeyInfo(repConfig, ONEMB - 1, dnMap); + ecb = new ECBlockInputStream(repConfig, ONEMB, + keyInfo, true, new TestBlockInputStreamFactory()); + Assert.assertTrue(ecb.hasSufficientLocations()); + ecb.close(); + + // EC-3-2, 1MB block but only location is in slot 2 (should never happen) + dnMap.clear(); + dnMap.put(MockDatanodeDetails.randomDatanodeDetails(), 2); + keyInfo = createKeyInfo(repConfig, ONEMB, dnMap); + ecb = new ECBlockInputStream(repConfig, ONEMB, + keyInfo, true, new TestBlockInputStreamFactory()); + Assert.assertFalse(ecb.hasSufficientLocations()); + ecb.close(); + + // EC-3-2, 5MB blocks, only 2 locations passed so we do not have sufficient + // locations. + dnMap.clear(); + dnMap.put(MockDatanodeDetails.randomDatanodeDetails(), 1); + keyInfo = createKeyInfo(repConfig, 5 * ONEMB, dnMap); + ecb = new ECBlockInputStream(repConfig, ONEMB, + keyInfo, true, new TestBlockInputStreamFactory()); + Assert.assertFalse(ecb.hasSufficientLocations()); + ecb.close(); + + // EC-3-2, 5MB blocks, only 1 data and 2 parity locations present. For now + // this will fail as we don't support reconstruction reads yet. + dnMap.clear(); + dnMap.put(MockDatanodeDetails.randomDatanodeDetails(), 1); + dnMap.put(MockDatanodeDetails.randomDatanodeDetails(), 4); + dnMap.put(MockDatanodeDetails.randomDatanodeDetails(), 5); + keyInfo = createKeyInfo(repConfig, 5 * ONEMB, dnMap); + ecb = new ECBlockInputStream(repConfig, ONEMB, + keyInfo, true, new TestBlockInputStreamFactory()); + Assert.assertFalse(ecb.hasSufficientLocations()); + ecb.close(); + } + + @Test + public void testCorrectBlockSizePassedToBlockStream() throws IOException { + ByteBuffer buf = ByteBuffer.allocate(3*ONEMB); + ECReplicationConfig repConfig = new ECReplicationConfig(3, 2); + + TestBlockInputStreamFactory streamFactory = + new TestBlockInputStreamFactory(); + ECBlockInputStream ecb = null; + List<TestBlockInputStream> streams = null; + OmKeyLocationInfo keyInfo = createKeyInfo(repConfig, 5, ONEMB - 100); + + // Block less than a single cell + try { + ecb = new ECBlockInputStream(repConfig, ONEMB, + keyInfo, true, streamFactory); + ecb.read(buf); + // We expect only 1 block stream and it should have a length passed of + // ONEMB - 100. + streams = streamFactory.getBlockStreams(); + Assert.assertEquals(ONEMB - 100, streams.get(0).getLength()); + } finally { + if (ecb != null) { + ecb.close(); + } + } + + // Block of two cells + try { + streamFactory = new TestBlockInputStreamFactory(); + keyInfo = createKeyInfo(repConfig, 5, ONEMB + 100); + ecb = new ECBlockInputStream(repConfig, ONEMB, + keyInfo, true, streamFactory); + buf.clear(); + ecb.read(buf); + streams = streamFactory.getBlockStreams(); + Assert.assertEquals(ONEMB, streams.get(0).getLength()); + Assert.assertEquals(100, streams.get(1).getLength()); + } finally { + ecb.close(); + } + + // Block of three cells + try { + streamFactory = new TestBlockInputStreamFactory(); + keyInfo = createKeyInfo(repConfig, 5, 2 * ONEMB + 100); + ecb = new ECBlockInputStream(repConfig, ONEMB, + keyInfo, true, streamFactory); + buf.clear(); + ecb.read(buf); + streams = streamFactory.getBlockStreams(); + Assert.assertEquals(ONEMB, streams.get(0).getLength()); + Assert.assertEquals(ONEMB, streams.get(1).getLength()); + Assert.assertEquals(100, streams.get(2).getLength()); + } finally { + ecb.close(); + } + + // Block of 3 full stripes and a partial stripe + try { + streamFactory = new TestBlockInputStreamFactory(); + keyInfo = createKeyInfo(repConfig, 5, 10 * ONEMB + 100); + ecb = new ECBlockInputStream(repConfig, ONEMB, + keyInfo, true, streamFactory); + buf.clear(); + ecb.read(buf); + streams = streamFactory.getBlockStreams(); + Assert.assertEquals(4 * ONEMB, streams.get(0).getLength()); + Assert.assertEquals(3 * ONEMB + 100, streams.get(1).getLength()); + Assert.assertEquals(3 * ONEMB, streams.get(2).getLength()); + } finally { + ecb.close(); + } + + // Single Full cell + try { + streamFactory = new TestBlockInputStreamFactory(); + keyInfo = createKeyInfo(repConfig, 5, ONEMB); + ecb = new ECBlockInputStream(repConfig, ONEMB, Review comment: OK - I have changed all the try to try with resources blocks and it makes things a bit cleaner. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
