GeorgeJahad commented on a change in pull request #2509:
URL: https://github.com/apache/ozone/pull/2509#discussion_r692374266
##########
File path:
hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestMultipartUploadWithCopy.java
##########
@@ -208,6 +218,73 @@ public void testMultipartIfModifiedSince() throws
Exception {
}
}
+ // Test operations with 2 datestrings; one valid, the other invalid;
+ // confirm the invalid one is ignored and the valid precondition tested
Review comment:
hey @kerneltime I've added the tests you suggested to
s3/endpoint/TestMultipartUploadWithCopy.java. There ended up being 25
different combinations total. I had to restructure the tests a bit to reduce
the repeated boilerplate. Hopefully those changes won't be too hard to follow.
Here are just the changes since your review, if that makes it easier:
https://github.com/GeorgeJahad/ozone/compare/3e7edd84a1a7cbf3e0c8a95c05ae971be171ffa1..f567f523bd12f88ff6db96c5cfdfa6d0a853399a#diff-bd6abd262ed8e24eaeea5cb0e7c2a1a128411b284f9f27dae1ad47be6717a940
Thanks again!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
