JacksonYao287 commented on a change in pull request #2538:
URL: https://github.com/apache/ozone/pull/2538#discussion_r693706461
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/impl/FilePerBlockStrategy.java
##########
@@ -95,15 +94,15 @@ public void writeChunk(Container container, BlockID
blockID, ChunkInfo info,
throws StorageContainerException {
checkLayoutVersion(container);
-
Preconditions.checkNotNull(dispatcherContext);
DispatcherContext.WriteChunkStage stage = dispatcherContext.getStage();
if (info.getLen() <= 0) {
if (LOG.isDebugEnabled()) {
LOG.debug("Skip writing empty chunk {} in stage {}", info, stage);
}
- return;
+ ExitUtils.terminate(1, "Empty Write chunk received " + info,
Review comment:
why we terminate here? is there something wrong if we just return?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
