bharatviswa504 commented on pull request #2491: URL: https://github.com/apache/ozone/pull/2491#issuecomment-906231351
> Thank you @bharatviswa504 for reviewing the PR. I have addressed some of your comments and replied to the rest. > > > One question what advantage of this validation compared to failing with exception, will we be in some inconsistent state? I just want to understand reason behind going this route. Because if any of the node is down, we cannot make use of this check i believe. > > If the config has not been updated on an OM and the SetConfiguration request is executed, then it could lead to that OM crashing out. If we perform this check before, we can avoid a healthy OM going down because of not updating its config with the new OM info. A healthy running OM should not crash when trying to add another OM. > > If a node is down, this check would at the very least warn the user to double check the configs before proceeding with force bootstapping. Thank You @hanishakoneru for the details. It would be good to have defensive checks instead of bringing down a cluster when a new node is added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
