Stephen O'Donnell created HDDS-5690:
---------------------------------------
Summary: Speed up TestContainerReplication by removing
testSkipDecommissionAndMaintenanceNode
Key: HDDS-5690
URL: https://issues.apache.org/jira/browse/HDDS-5690
Project: Apache Ozone
Issue Type: Improvement
Components: test
Affects Versions: 1.2.0
Reporter: Stephen O'Donnell
Assignee: Stephen O'Donnell
TestContainerReplication#testSkipDecommissionAndMaintenanceNode() was added as
part of HDDS-5296. The test runs 3 times and sleeps for 30 seconds on each run
to wait to ensure replication never hits an out of service node. Aside from the
30 second sleep, each run of the test takes about 1 minute, so 3 minutes in
total for this test.
This class takes about 370 seconds on every pull request:
{code}
[INFO] Running org.apache.hadoop.ozone.container.TestContainerReplication
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 368.92 s
- in org.apache.hadoop.ozone.container.TestContainerReplication
{code}
I feel this integration test is not needed. The logic we are testing here, is
actually part of the placement policy and we can test for the original defect
in TestSCMContainerPlacementRackAware much more efficiently and reliably.
Here I have added a new test to TestSCMContainerPlacementRackAware and removed
the test mentioned above.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
