wzhallright commented on pull request #2599:
URL: https://github.com/apache/ozone/pull/2599#issuecomment-910122292
> @wzhallright , what is the log after the patch, could you paste an example
here?
Thanks for review.
The fail log is
`2021-09-01 17:41:09,660 | ERROR | SCMAudit | user=ozone | ip=localhost |
op=REGISTER {datanodeDetails=d68d781c-e720-4107-8b47-eb59a5e6cfd7{ip:
localhost, host: , ports: [REPLICATION=9886, RATIS=9858, RATIS_ADMIN=9857,
RATIS_SERVER=9856, STANDALONE=9859], networkLocation: /default-rack,
certSerialId: null, persistedOpState: IN_SERVICE,
persistedOpStateExpiryEpochSec: 0}} | ret=FAILURE |`
If I modify it like this PR，when getRegisterResponse(registeredCommand)
throw exception, the audit will log twice.
So, I'm wondering if I need to add a boolean parameter for
ErrorCode.errorNodeNotPermitted when log audit in finally.
Do you have any suggestions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
