Xushaohong commented on pull request #2622: URL: https://github.com/apache/ozone/pull/2622#issuecomment-915809805
> LGTM, can we do similar change for OM also? OM uses OmNodeId as RaftPeerID, such as "om1" "om2" "om3 ", while SCM use scmUUID as RaftPeerID, and thus the log trace could be confusing for finding the right SCM node. Right now the OM side will print NodeId, i am wandering the followings: 1. should we unifiy the RaftPeerId usage for OM and SCM ? (obviously UUID is better for indicating the physical node) 2. after that we could unify the pattern the getting om/scm roles return -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
