szetszwo commented on a change in pull request #2640:
URL: https://github.com/apache/ozone/pull/2640#discussion_r709002502
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/common/Checksum.java
##########
@@ -154,11 +158,6 @@ public ChecksumData computeChecksum(List<ByteString>
byteStrings)
public ChecksumData computeChecksum(ChunkBuffer data)
throws OzoneChecksumException {
- if (checksumType == ChecksumType.NONE) {
- // Since type is set to NONE, we do not need to compute the checksums
- return new ChecksumData(checksumType, bytesPerChecksum);
- }
-
Review comment:
On a second thought, we should not remove this if-statement since some
other code paths depend on it. Let's revert the commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
