sodonnel commented on pull request #2639: URL: https://github.com/apache/ozone/pull/2639#issuecomment-920108702
Summarising a conversation we had on slack. I'd prefer to avoid creating a new mini-cluster to test this, as each time we add a new one, it adds about 40 seconds to the build time. For the CLI logic, testing it handles its arguments properly and constructs the correct call to the Client API, a unit test similar to TestDecommissionSubCommand is ideal, with a mocked client. As the test here was taken from TestOzoneShellHA, it already creates a mini-cluster in a BeforeClass method, and runs many tests, so we could also runs these tests there but extending that test too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
