bharatviswa504 commented on a change in pull request #2525:
URL: https://github.com/apache/ozone/pull/2525#discussion_r711622194
##########
File path:
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/container/TestContainerStateManagerIntegration.java
##########
@@ -102,7 +100,7 @@ public void testAllocateContainer() throws IOException {
SCMTestUtils.getReplicationFactor(conf), OzoneConsts.OZONE);
ContainerInfo info = containerManager
.getMatchingContainer(OzoneConsts.GB * 3, OzoneConsts.OZONE,
- container1.getPipeline());
+ container1.getPipeline(), excludedContainerIDS);
Review comment:
We still have old method which is defined in interface
ContainerManager.java
default ContainerInfo getMatchingContainer(long size, String owner,
Pipeline pipeline) {
return getMatchingContainer(size, owner, pipeline,
Collections.emptySet());
}
But I think that is fine, as anyway for tests we are passing empty hashset
for excludedContainerIDS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
