adoroszlai commented on a change in pull request #2662:
URL: https://github.com/apache/ozone/pull/2662#discussion_r712240983
##########
File path:
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOmMetrics.java
##########
@@ -367,6 +376,13 @@ public void testAclOperations() throws IOException {
@Test
public void testAclOperationsHA() throws Exception {
+ // This test needs a cluster with DNs and SCM to wait on safemode
+ cluster.shutdown();
Review comment:
This looks a bit strange. Would it be better to get rid of `@Before`
and explicitly create cluster with desired properties for each test? (Similar
to what `TestOzoneManagerListVolumes` [did
before](https://github.com/apache/ozone/blob/aae9ebd948e2b57bb947446d3b8fda9969cd6d47/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerListVolumes.java#L197-L200)
HDDS-5717.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
