sodonnel commented on a change in pull request #2653: URL: https://github.com/apache/ozone/pull/2653#discussion_r712466962
########## File path: hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/BlockInputStreamFactoryImpl.java ########## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.ozone.client.io; + +import org.apache.hadoop.hdds.client.BlockID; +import org.apache.hadoop.hdds.client.ECReplicationConfig; +import org.apache.hadoop.hdds.client.ReplicationConfig; +import org.apache.hadoop.hdds.protocol.proto.HddsProtos; +import org.apache.hadoop.hdds.scm.XceiverClientFactory; +import org.apache.hadoop.hdds.scm.pipeline.Pipeline; +import org.apache.hadoop.hdds.scm.storage.BlockExtendedInputStream; +import org.apache.hadoop.hdds.scm.storage.BlockInputStream; +import org.apache.hadoop.hdds.security.token.OzoneBlockTokenIdentifier; +import org.apache.hadoop.ozone.om.helpers.OmKeyLocationInfo; +import org.apache.hadoop.security.token.Token; + +import java.util.function.Function; + +/** + * Factory class to create various BlockStream instances. + */ +public class BlockInputStreamFactoryImpl implements BlockInputStreamFactory { + + public static BlockInputStreamFactory getInstance() { + return new BlockInputStreamFactoryImpl(); + } + + /** + * Create a new BlockInputStream from the given parameters. + * @param blockId The blockID + * @param blockLen The Block Length + * @param pipeline The pipeline used to read from the block + * @param token The block access token + * @param verifyChecksum Whether to verify checksums or not + * @param xceiverFactory Factor to create the xceiver in the client + * @param refreshFunction Function to refresh the pipeline if needed. + * @return A BlockInputStream instance + */ Review comment: I started to remove this extra API, but then I ran into a small problem in ECBlockInputStream - I cannot just pass the blockInfo it receives through to the factory, as the blockInfo.getLength is the length of the blockGroup, so I need to change it. So I went ahead and updated it to see if it looks better, which it probably does. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
