rakeshadr commented on a change in pull request #2561:
URL: https://github.com/apache/ozone/pull/2561#discussion_r717185468



##########
File path: 
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
##########
@@ -3110,4 +3117,8 @@ public boolean isBucketFSOptimized(String volName, String 
buckName)
     }
     return false;
   }
+
+  public BucketLayout getBucketLayout() {
+    return BucketLayout.DEFAULT;

Review comment:
       @aryangupta1998  Its hard coded to DEFAULT/LEGACY. This is the reason 
for the test case failure 
`TestOzoneClientMultipartUploadWithFSO.testListPartsWithPartMarkerGreaterThanPartCount`.
 
[Failed_Build](https://github.com/apache/ozone/pull/2561/checks?check_run_id=3722349964).
   
   getBucketLayout() has to be determined from bucket for the functions that 
are common to non-FSO and FSO.
   
   Following methods in KeyManagerImpl has common for non-FSO and FSO execution 
path. Please modify these calls by reading bucketLayout from OmBucketInfo.
   KeyManagerImpl#checkAccess() -> getBucketLayout()
   and
   KeyManagerImpl#listParts() -> getBucketLayout()




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to