JyotinderSingh commented on a change in pull request #2689:
URL: https://github.com/apache/ozone/pull/2689#discussion_r718201311
##########
File path:
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerHA.java
##########
@@ -171,22 +173,29 @@ public void init() throws Exception {
*/
conf.set(OZONE_BLOCK_DELETING_SERVICE_INTERVAL, "10s");
conf.set(OZONE_KEY_DELETING_LIMIT_PER_TASK, "2");
- additionalConfiguration();
clusterBuilder = MiniOzoneCluster.newOMHABuilder(conf)
.setClusterId(clusterId)
.setScmId(scmId)
.setOMServiceId(omServiceId)
.setOmId(omId)
.setNumOfOzoneManagers(numOfOMs);
- additionalClusterSettings();
- cluster = (MiniOzoneOMHAClusterImpl)clusterBuilder.build();
+ cluster = (MiniOzoneOMHAClusterImpl) clusterBuilder.build();
cluster.waitForClusterToBeReady();
objectStore = OzoneClientFactory.getRpcClient(omServiceId, conf)
.getObjectStore();
}
+ /**
+ * Apply additional configuration between tests.
+ */
+ @Before
+ public void setupTest() {
Review comment:
Understood, will add these changes
##########
File path:
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerPrepare.java
##########
@@ -175,7 +184,11 @@ public void testPrepareDownedOM() throws Exception {
@Test
public void testPrepareWithRestart() throws Exception {
+ // Create fresh cluster for this test to prevent timeout from restarting
Review comment:
This was working without the need for a new cluster on my local system
as well. But yesterday this test timed out on CI (while executing < 10s on my
local) - and I thought that this might solve the issue.
Might have been some CI related issue. Will remove this and run checks again
to see if it still persists.
##########
File path:
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerPrepare.java
##########
@@ -175,7 +184,11 @@ public void testPrepareDownedOM() throws Exception {
@Test
public void testPrepareWithRestart() throws Exception {
+ // Create fresh cluster for this test to prevent timeout from restarting
Review comment:
Here's the link to the CI run:
https://github.com/apache/ozone/runs/3734530549#step:4:2979
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
