bharatviswa504 commented on a change in pull request #2707:
URL: https://github.com/apache/ozone/pull/2707#discussion_r722747544
##########
File path: hadoop-hdds/docs/content/feature/PrefixFSO.md
##########
@@ -72,4 +72,17 @@ By default the feature is disabled. It can be enabled with
the following
<name>ozone.om.metadata.layout</name>
<value>PREFIX</value>
</property>
+```
+
+In reference to efforts towards supporting protocol aware buckets within a
+single OM, the following configurations can be used to define the default value
Review comment:
remove single here. it is causing confusion here.
We can instead say in a ozone cluster
##########
File path: hadoop-hdds/common/src/main/resources/ozone-default.xml
##########
@@ -2988,4 +2988,14 @@
OM/SCM/DN/S3GATEWAY Server connection timeout in milliseconds.
</description>
</property>
+
+ <property>
+ <name>ozone.default.bucket.layout</name>
+ <value>OBJECT_STORE</value>
+ <tag>OZONE, MANAGEMENT</tag>
+ <description>
+ Default bucket layout used by Ozone Manager during bucket creation when
a client does not specify the
Review comment:
Can you also specify what are the supported values here, and little bit
explanation about each value?
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
##########
@@ -4072,6 +4074,11 @@ public String getOMMetadataLayout() {
.getTrimmed(OZONE_OM_METADATA_LAYOUT,
OZONE_OM_METADATA_LAYOUT_DEFAULT);
}
+ public String getOMDefaultBucketLayout() {
Review comment:
Instead of reading every time from config during bucket creation, we can
read once validate it.
This will make easy during bucket creation, the string value we have is a
appropriate value.
##########
File path: hadoop-hdds/docs/content/feature/PrefixFSO.md
##########
@@ -72,4 +72,17 @@ By default the feature is disabled. It can be enabled with
the following
<name>ozone.om.metadata.layout</name>
<value>PREFIX</value>
</property>
+```
+
+In reference to efforts towards supporting protocol aware buckets within a
+single OM, the following configurations can be used to define the default value
Review comment:
if the client is not
passing the bucket layout argument -> if the client has not specified the
bucket layout argument
##########
File path: hadoop-hdds/docs/content/feature/PrefixFSO.md
##########
@@ -72,4 +72,17 @@ By default the feature is disabled. It can be enabled with
the following
<name>ozone.om.metadata.layout</name>
<value>PREFIX</value>
</property>
+```
+
+In reference to efforts towards supporting protocol aware buckets within a
+single OM, the following configurations can be used to define the default value
Review comment:
configurations -> configuration
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/OMBucketCreateRequest.java
##########
@@ -145,12 +143,9 @@ public OMClientResponse
validateAndUpdateCache(OzoneManager ozoneManager,
OmBucketInfo omBucketInfo = null;
if (bucketInfo.getBucketLayout() == null || bucketInfo.getBucketLayout()
.equals(BucketLayoutProto.LEGACY)) {
Review comment:
Not understood why when it is legacy also we use default type here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
