bharatviswa504 commented on a change in pull request #2707:
URL: https://github.com/apache/ozone/pull/2707#discussion_r724623031
##########
File path: hadoop-hdds/common/src/main/resources/ozone-default.xml
##########
@@ -2813,7 +2813,7 @@
<tag>OZONE, SCM</tag>
<description>Thread pool size configured to process container reports.
</description>
- </property>
+ </property>
Review comment:
Minor NIT: unnecessary change
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
##########
@@ -452,6 +455,9 @@ private OzoneManager(OzoneConfiguration conf, StartupOption
startupOption)
isRatisEnabled = configuration.getBoolean(
OMConfigKeys.OZONE_OM_RATIS_ENABLE_KEY,
OMConfigKeys.OZONE_OM_RATIS_ENABLE_DEFAULT);
+ this.defaultBucketLayout =
+ configuration.getTrimmed(OZONE_DEFAULT_BUCKET_LAYOUT,
+ OZONE_DEFAULT_BUCKET_LAYOUT_DEFAULT);
Review comment:
Do we want to validate it here? If it is one of the supported values and
fail startup here?
##########
File path: hadoop-hdds/common/src/main/resources/ozone-default.xml
##########
@@ -2108,7 +2108,7 @@
not be renewed.
</description>
</property>
-
+
Review comment:
Minor NIT: unnecessary change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
