JyotinderSingh commented on a change in pull request #2707: URL: https://github.com/apache/ozone/pull/2707#discussion_r725306333
########## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestObjectStore.java ########## @@ -0,0 +1,103 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with this + * work for additional information regarding copyright ownership. The ASF + * licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations under + * the License. + */ +package org.apache.hadoop.ozone.om; + +import org.apache.hadoop.hdds.conf.OzoneConfiguration; +import org.apache.hadoop.ozone.MiniOzoneCluster; +import org.apache.hadoop.ozone.client.*; +import org.apache.hadoop.ozone.om.helpers.BucketLayout; +import org.junit.*; +import org.junit.rules.Timeout; + +import java.io.IOException; +import java.util.UUID; + +/** + * Tests to verify Object store without prefix enabled. + */ +public class TestObjectStore { + private static MiniOzoneCluster cluster = null; + private static OzoneConfiguration conf; + private static String clusterId; + private static String scmId; + private static String omId; + + @Rule + public Timeout timeout = new Timeout(1200000); + + /** + * Create a MiniOzoneCluster for testing. + * <p> + * + * @throws IOException + */ + @BeforeClass + public static void init() throws Exception { + conf = new OzoneConfiguration(); + clusterId = UUID.randomUUID().toString(); + scmId = UUID.randomUUID().toString(); + omId = UUID.randomUUID().toString(); + cluster = MiniOzoneCluster.newBuilder(conf).setClusterId(clusterId) + .setScmId(scmId).setOmId(omId).build(); + cluster.waitForClusterToBeReady(); + } + + /** + * Shutdown MiniOzoneCluster. + */ + @AfterClass + public static void shutdown() { + if (cluster != null) { + cluster.shutdown(); + } + } + + @Test + public void testCreateBucketWithBucketLayout() throws Exception { + String sampleVolumeName = UUID.randomUUID().toString(); + String sampleBucketName = UUID.randomUUID().toString(); + OzoneClient client = cluster.getClient(); + ObjectStore store = client.getObjectStore(); + store.createVolume(sampleVolumeName); + OzoneVolume volume = store.getVolume(sampleVolumeName); + + // Case 1: Bucket layout: Empty and OM default bucket layout: OBJECT_STORE + BucketArgs.Builder builder = BucketArgs.newBuilder(); + volume.createBucket(sampleBucketName, builder.build()); + OzoneBucket bucket = volume.getBucket(sampleBucketName); + Assert.assertEquals(sampleBucketName, bucket.getName()); + Assert.assertEquals(BucketLayout.OBJECT_STORE, + bucket.getBucketLayout()); + + // Case 2: Bucket layout: DEFAULT + sampleBucketName = UUID.randomUUID().toString(); + builder.setBucketLayout(BucketLayout.DEFAULT); + volume.createBucket(sampleBucketName, builder.build()); + bucket = volume.getBucket(sampleBucketName); + Assert.assertEquals(sampleBucketName, bucket.getName()); + Assert.assertEquals(BucketLayout.OBJECT_STORE, + bucket.getBucketLayout()); + + // Case 3: Bucket layout: LEGACY + sampleBucketName = UUID.randomUUID().toString(); + builder.setBucketLayout(BucketLayout.LEGACY); + volume.createBucket(sampleBucketName, builder.build()); Review comment: I have raised [HDDS-5841](https://issues.apache.org/jira/browse/HDDS-5841) for tracking this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
