sadanand48 commented on pull request #2701:
URL: https://github.com/apache/ozone/pull/2701#issuecomment-940070714
Thanks @szetszwo and @bshashikant for the review. Yes I will be adding
more tests. Also , we are not using `BufferPool`
here instead maintaining a list that contains a reference to the buffers
that are passed by the client. Currently we maintain a `commitIndexMap` which
contains list of buffers for a particular commitIndex and the buffers are
discarded from the list during stream watchForCommit.
Currently on retry , we discard the previous buffers in the bufferList and
start from 0 regardless of whether all the nodes have upto certain data. In a
follow up task , I will maintain stream ack like you suggested and only retry
writing the data that is not present in all nodes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
